Bump the pc plugin from 1.8.0 to 1.15.0 - #4243
Open
tas50 wants to merge 1 commit into
Open
Conversation
port_compiler 1.8.0 does not build on OTP 27. Its pc_port_env module
calls the two-argument code:lib_dir/2, deprecated in OTP 27, and rebar3
compiles plugins with warnings as errors, so the plugin fails to load
before any of oc_bifrost is compiled:
===> Compiling _build/default/plugins/pc/src/pc_port_env.erl failed
pc_port_env.erl:197:10: code:lib_dir/2 is deprecated; this
functionality will be removed in a future release
===> Errors loading plugin {pc,"1.8.0"}
1.15.0 uses the single-argument code:lib_dir/1, which is not deprecated.
The pin's stated reason no longer applies. The comment cites
port_compiler issue 43, which was closed on 2018-05-02; v1.10.0 was
released two weeks later. oc_erchef and bookshelf already depend on pc
unpinned and therefore already resolve 1.15.0 -- oc_bifrost is the only
one held back.
Verified against erlang:26 and erlang:27 containers (the latter with
require_otp_vsn relaxed, since that gate is a separate matter):
- OTP 26, pc 1.15.0: oc_bifrost compiles, no regression.
- OTP 27, pc 1.8.0: plugin fails to load, as above.
- OTP 27, pc 1.15.0: plugin loads, no code:lib_dir/2 diagnostics.
This does not make oc_bifrost build on OTP 27 on its own; it removes the
first blocker. The next one is mochiweb, whose mochiweb_multipart module
trips unused-function warnings under warnings_as_errors. That is a
separate change.
Signed-off-by: Tim Smith <tim@mondoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port_compiler 1.8.0 does not build on OTP 27. Its
pc_port_envmodule calls the two-argumentcode:lib_dir/2, deprecated in OTP 27, and rebar3 compiles plugins with warnings as errors — so the plugin fails to load before any ofoc_bifrostis compiled:1.15.0 uses the single-argument
code:lib_dir/1, which is not deprecated.The pin's stated reason no longer applies
The comment cites port_compiler#43, closed 2018-05-02; v1.10.0 shipped two weeks later.
oc_erchefandbookshelfalready depend onpcunpinned, so they resolve 1.15.0 today.oc_bifrostis the only one held back — this brings it in line.Verified
Against
erlang:26anderlang:27containers (the latter withrequire_otp_vsnrelaxed, since that gate is a separate matter):Compiling bifrost— no regressioncode:lib_dir/2diagnosticsScope
This does not make
oc_bifrostbuild on OTP 27 on its own — it removes the first blocker. The next ismochiweb, whosemochiweb_multipartmodule trips unused-function warnings underwarnings_as_errors. That is a separate change.