feature/INT-1637 - Payment Request Product Type and Subtype to nullable#216
Merged
Conversation
armando-rodriguez-cko
approved these changes
Jun 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request updates the
Productmodel to use strongly-typed enums for thetypeandsub_typefields and ensures that these enums serialize to lowercase strings, improving consistency and type safety. It also introduces a comprehensive test suite to verify correct serialization behavior, including handling ofNonevalues.Model and Enum Refactoring
ItemTypeenum and updated theProductclass to useItemTypeandProductSubTypeenums for thetypeandsub_typefields, respectively, instead of plain strings. The enums now serialize as lowercase values for consistency. (checkout_sdk/payments/payments.py, checkout_sdk/payments/payments.pyR627-R643)ProductSubTypeenum values to be lowercase, aligning with serialization expectations. (checkout_sdk/payments/payments.py, checkout_sdk/payments/payments.pyR627-R643)Serialization and Testing
product_serialization_test.pywith tests to ensure thatProductserializestypeandsub_typefields as lowercase strings, supportsNonevalues, and round-trips all fields correctly. (tests/payments/product_serialization_test.py, tests/payments/product_serialization_test.pyR1-R99)Typing Improvements
Optionalimport fromtypingto support optional enum fields in the model. (checkout_sdk/payments/payments.py, checkout_sdk/payments/payments.pyR5)