Repository navigation
ci: keep a failed Slack notification from failing a release [ship] - #1589
Merged
Merged
Conversation
The 10.1.0 release stopped after both prerelease packages were published. The Slack webhook answered 403, which failed the prerelease job. The release job depends on it, so the production approval never appeared. The four Slack notification steps now continue on error.
kiroushi
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kiroushi
enabled auto-merge (squash)
October 29, 2026 18:26
kiroushi
disabled auto-merge
October 29, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components
Notes for the Reviewer
The 10.1.0 release stopped after both prerelease packages were published: the Slack webhook answered
403 Forbidden, the "Slack Success Notification" step failed theprereleasejob, and thereleasejob (with the production approval) depends on it. The webhook worked for 10.0.0 on 2026-10-26.The four Slack notification steps in
release.ymlnow usecontinue-on-error: true, so a broken webhook no longer blocks a release. TheSLACK_WEBHOOKsecret still needs replacing for the notifications to arrive again.