feat: add timezone and pause/silence scope to the maintenance window construct - #1466
Draft
shiini2 wants to merge 1 commit into
Draft
feat: add timezone and pause/silence scope to the maintenance window construct#1466shiini2 wants to merge 1 commit into
shiini2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
timezone,pauseAllChecks,silenceAlertsTagsandsilenceAllAlertsto theMaintenanceWindowconstruct — all four are already accepted by the CLI deploy schema, so they were being silently stripped from any config that tried to set them.tagsis now optional. The backend has always had it as.optional().default([]), and requiring it made no sense oncepauseAllChecksexists — pausing every check in the account shouldn't need a tag list. Loosening a required prop is backwards-compatible.The codegen twin is updated too, so
checkly importround-trips the new properties instead of dropping them. Booleans follow the existing convention of emitting only when they differ from the backend default.Independent of the Go chain — this talks to the API directly and isn't gated on any release.