Unit testing improvements by MoralCode · Pull Request #323 · chaoss/CollectOSS

MoralCode · 2026-05-18T18:48:39Z

Description
This PR makes general improvements to testing, including:

adding unit tests for new endpoint url behavior introduced in Bypass collecting pull request data when PRs are disabled #306
moves some imports to remove one of the several roadblocks to improving application unit test coverage.
actually run all the tests configured in the .toml file
reorganize and improve labeling of some of the tests

Notes for Reviewers
This PR contains some signed-off contributions from @Inengs that were originally filed as augurlabs/augur#3749 (adding unit tests for the ContributorUUID class, which was renamed as part of the fork)

Ill consider this tested if all CI tests pass

Signed commits

Yes, I signed my commits.

Signed-off-by: Inengs <inengiyeemmanuel@gmail.com>

Signed-off-by: Inengiye Emmanuel <inengiyeemmanuel@gmail.com>

…intended These pass but require that the collectoss/tasks/github/__init__.py file be commented out first before they will run Co-Authored-By: Cursor Signed-off-by: Adrian Edwards <adredwar@redhat.com>

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

this prevents them from messing with unit testing stuff Signed-off-by: Adrian Edwards <adredwar@redhat.com>

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

…ments

github-advanced-security

Bandit found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

github-actions · 2026-05-18T18:49:26Z

+
+
+@pytest.fixture
+def gda(mock_key_manager, mock_logger):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_key_manager' from outer scope (line 14) (redefined-outer-name)

github-actions · 2026-05-18T18:49:26Z

+
+
+@pytest.fixture
+def gda(mock_key_manager, mock_logger):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_logger' from outer scope (line 9) (redefined-outer-name)

github-actions · 2026-05-18T18:49:26Z

+
+class TestEndpointUrl:
+
+    def test_basic_path(self, gda):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'gda' from outer scope (line 19) (redefined-outer-name)

github-actions · 2026-05-18T18:49:26Z

+        result = gda.endpoint_url("/users/MoralCode")
+        assert result == "https://api.github.com/users/MoralCode"
+
+    def test_path_without_leading_slash(self, gda):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'gda' from outer scope (line 19) (redefined-outer-name)

github-actions · 2026-05-18T18:49:27Z

+        result = gda.endpoint_url("repos/owner/repo")
+        assert result == "https://api.github.com/repos/owner/repo"
+
+    def test_with_single_param(self, gda):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'gda' from outer scope (line 19) (redefined-outer-name)

github-actions · 2026-05-18T18:49:27Z

+        result = gda.endpoint_url("/users/MoralCode", {})
+        assert result == "https://api.github.com/users/MoralCode"
+
+    def test_path_with_existing_query_params(self, gda):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'gda' from outer scope (line 19) (redefined-outer-name)

github-actions · 2026-05-18T18:49:27Z

+    uid = GithubUUID()
+    uid["user"] = 10
+
+    result = uid.__dict__()


[pylint] _{reported by reviewdog 🐶}
E1102: uid.dict is not callable (not-callable)

github-actions · 2026-05-18T18:49:27Z

@@ -0,0 +1,160 @@
+import pytest
+import uuid
+from collectoss.tasks.util.ContributorUUID import ContributorUUID, GithubUUID, GitlabUUID, UnresolvableUUID


[pylint] _{reported by reviewdog 🐶}
W0611: Unused UnresolvableUUID imported from collectoss.tasks.util.ContributorUUID (unused-import)

github-actions · 2026-05-18T18:49:27Z

@@ -2,11 +2,11 @@
 import pytest


[pylint] _{reported by reviewdog 🐶}
W0611: Unused import pytest (unused-import)

github-actions · 2026-05-18T18:49:27Z

@@ -2,11 +2,11 @@
 import pytest
 import sqlalchemy as s


[pylint] _{reported by reviewdog 🐶}
W0611: Unused sqlalchemy imported as s (unused-import)

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

github-actions · 2026-05-19T15:57:44Z

-        getattr(cfg, callable_name)(*args, **kwargs)
+class TestJSONConfig:

+    def test_jsonconfig_readonly_flags(self, mock_logger):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_logger' from outer scope (line 9) (redefined-outer-name)

github-actions · 2026-05-19T15:57:44Z

+        assert cfg.empty is False

+
+    def test_jsonconfig_empty_true_false(self, mock_logger):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_logger' from outer scope (line 9) (redefined-outer-name)

github-actions · 2026-05-19T15:57:44Z

+        assert JsonConfig({"A": {}}, mock_logger).empty is False
+
+
+    def test_jsonconfig_write_protection(self, mock_logger):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_logger' from outer scope (line 9) (redefined-outer-name)

github-actions · 2026-05-19T15:57:44Z

+        config_test = cfg.retrieve_dict() 
+        assert config_test != data # the data in the config should not change
+
+    def test_jsonconfig_retrieve_has_get(self, mock_logger):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_logger' from outer scope (line 9) (redefined-outer-name)

github-actions · 2026-05-19T15:57:44Z

+            ("add_value", ("X", "y", 2), {"ignore_existing": False}),
+        ],
+    )
+    def test_jsonconfig_mutations_raise_not_writable(self, mock_logger, callable_name, args, kwargs):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_logger' from outer scope (line 9) (redefined-outer-name)

github-actions · 2026-05-19T15:57:44Z

+            getattr(cfg, callable_name)(*args, **kwargs)
+
+
+    def test_fetching_real_defaults(self, mock_logger, mock_session):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_logger' from outer scope (line 9) (redefined-outer-name)

github-actions · 2026-05-19T15:57:44Z

+            getattr(cfg, callable_name)(*args, **kwargs)
+
+
+    def test_fetching_real_defaults(self, mock_logger, mock_session):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'mock_session' from outer scope (line 13) (redefined-outer-name)

github-actions · 2026-05-19T15:57:44Z

    assert len_contributors_list == 0

-def test_github_paginator_get_item(key_auth):
+def test_github_paginator_get_item_2(key_auth):


[pylint] _{reported by reviewdog 🐶}
W0621: Redefining name 'key_auth' from outer scope (line 14) (redefined-outer-name)

github-actions · 2026-05-19T15:57:44Z

+        uid = GithubUUID()
+        uid["user"] = 10
+
+        result = uid.__dict__()


[pylint] _{reported by reviewdog 🐶}
E1102: uid.dict is not callable (not-callable)

github-actions · 2026-05-19T15:57:44Z

@@ -0,0 +1,161 @@
+import pytest
+import uuid
+from collectoss.tasks.util.ContributorUUID import ContributorUUID, GithubUUID, GitlabUUID, UnresolvableUUID


[pylint] _{reported by reviewdog 🐶}
W0611: Unused UnresolvableUUID imported from collectoss.tasks.util.ContributorUUID (unused-import)

Inengs and others added 10 commits May 18, 2026 14:42

tests: add unit tests for AugurUUID and subclasses

6b23c40

Signed-off-by: Inengs <inengiyeemmanuel@gmail.com>

tests: add test_augur_uuid.py to pytest testpaths in pyproject.toml

f87fda6

Signed-off-by: Inengs <inengiyeemmanuel@gmail.com>

tests: add edge case and boundary tests for AugurUUID

a1ae7a5

Signed-off-by: Inengs <inengiyeemmanuel@gmail.com>

Remove redundant UUID tests

29ce958

Signed-off-by: Inengiye Emmanuel <inengiyeemmanuel@gmail.com>

add some basic unit tests to assert that the URL generation works as …

e87983d

…intended These pass but require that the collectoss/tasks/github/__init__.py file be commented out first before they will run Co-Authored-By: Cursor Signed-off-by: Adrian Edwards <adredwar@redhat.com>

fix merge conflict error

e6976be

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

move task imports to the one place they're actually needed

c47b20b

this prevents them from messing with unit testing stuff Signed-off-by: Adrian Edwards <adredwar@redhat.com>

rename the class

309f852

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

fix remove database dependency from the worker util test

a63d96a

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

Merge branch 'Inengs/unit-tests/augur-uuid' into unit_testing_improve…

1657cd2

…ments

github-advanced-security AI found potential problems May 18, 2026

View reviewed changes

github-actions Bot reviewed May 18, 2026

View reviewed changes

MoralCode added 6 commits May 19, 2026 09:06

actually run all the configured tests in CI

ecfa0d7

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

rename duplicate test function

bc66238

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

refactor most of the JSONConfig store tests into a class

5840b23

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

encapsulate contributor UUID into a class

606024d

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

rename unit test file

9199b85

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

configure and apply test markers to separate unit and integration tests

1c23358

Signed-off-by: Adrian Edwards <adredwar@redhat.com>

github-actions Bot reviewed May 19, 2026

View reviewed changes

MoralCode merged commit 3bf9696 into main May 20, 2026
19 of 20 checks passed

MoralCode deleted the unit_testing_improvements branch May 20, 2026 18:26

		assert cfg.empty is False


		def test_jsonconfig_empty_true_false(self, mock_logger):

		assert JsonConfig({"A": {}}, mock_logger).empty is False


		def test_jsonconfig_write_protection(self, mock_logger):

		getattr(cfg, callable_name)(args, *kwargs)


		def test_fetching_real_defaults(self, mock_logger, mock_session):

Conversation

MoralCode commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-advanced-security AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MoralCode commented May 18, 2026 •

edited

Loading