Repository navigation
Accept readonly arrays in detect order option - #51
Merged
Merged
Conversation
Netail
approved these changes
Oct 22, 2026
Netail
reviewed
Oct 22, 2026
| * @default ["dprint", "deno", "oxfmt", "biome", "prettier"] // from `defaultDetectOrder` | ||
| */ | ||
| order?: FormatterName[]; | ||
| order?: readonly FormatterName[]; |
There was a problem hiding this comment.
Will break mutable arrays tho, in case we need to filter later again
Member
Author
There was a problem hiding this comment.
both are OK:
type Formatter = "dprint" | "deno" | "oxfmt" | "biome" | "prettier";
declare function test(options: { formatters?: readonly Formatter[] }): void;
declare const ro: readonly Formatter[];
declare const mutable: Formatter[];
test({
formatters: ro, // ok
});
test({
formatters: mutable, // ok
});Internally we can always make a copy if needed, we shouldn't mutate the input array anyway.
bluwy
approved these changes
Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.