Fixes issues #38 #39: Save initial gpio Line_Request object, do not release gio lines at every gpio action#40
Open
wke67 wants to merge 10 commits intochandrawi:mainfrom
Open
Fixes issues #38 #39: Save initial gpio Line_Request object, do not release gio lines at every gpio action#40wke67 wants to merge 10 commits intochandrawi:mainfrom
wke67 wants to merge 10 commits intochandrawi:mainfrom
Conversation
wke67
commented
Mar 17, 2026
- The code for Class LoRaGpio is using a with statement to do operations on a gpio line. This will always request the gpio line, do some operation, and release the gpio line thereafter. This will have the effect of resetting the event counter every time monitor() is called. Instead, the gpio line must be requested once, the Line_Request object saved, and used for all future accesses to the gpio line. The same has been done for the input and output methods of class LoRaGpio. This fixes issues LoRaGpio: method monitor_continuous(...) not implemented #38, Class LoRaGpio method monitor(...) does not work as expected. #39.
- A change in SX127x.py allows to set the chip-select (cs) gpio line to None - many drivers/devices provide a fixed chip-select line and a gpio is not required.
- Updated requirements in setup.cfg
…te the the Line_Request object once, and use it for all future actions. issues chandrawi#38, chandrawi#39
libgpiod >2.0.2 requires pyhton3 > 3.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.