feat(cli): configurable gRPC max receive message size#3141
Open
lemonprogis wants to merge 1 commit into
Open
Conversation
…rger workflow runs Signed-off-by: lemonprogis <edward.briggler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CLI's gRPC client used gRPC's built-in 4 MiB cap on incoming unary messages, which is below what some control-plane responses (notably
workflow run describewith many materials/policies) now produce. Hitting it failed the command withgrpc: received message larger than max. Raisingmax_recv_msg_sizeon the control plane didn't help because that knob governs server-inbound, not the CLI's receive side.Changes
pkg/grpcconnnow applies a boundedDefaultMaxRecvMsgSizeof 32 MiB to all client connections, replacing gRPC's 4 MiB default.grpcconn.WithMaxRecvMsgSize(int)option for explicit overrides.--max-recv-msg-size, config keyapi-max-recv-msg-size, and env varCHAINLOOP_API_MAX_RECV_MSG_SIZE.0keeps the default.cmd/root.goandcmd/artifact.go.Server-side
max_recv_msg_size(already exposed in control-plane config) and the new client-side flag are now symmetric, documented knobs.Related to #3048
AI disclosure
Assisted by Claude Code.