Skip to content

feat(dagger): Allow github and gitlab PR related env on Dagger runner #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javirln merged 3 commits into from
Jan 8, 2026
+35 −4
Merged

feat(dagger): Allow github and gitlab PR related env on Dagger runner #2646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cdcf24
feat(dagger): Allow github and gitlab PR related env on Dagger runner
javirln Jan 8, 2026
132f560
update date
javirln Jan 8, 2026
2cf7aaf
modify tests
javirln Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion pkg/attestation/crafter/runners/daggerpipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2024 The Chainloop Authors.
// Copyright 2024-2026 The Chainloop Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -45,6 +45,20 @@ func (r *DaggerPipeline) ListEnvVars() []*EnvVarDefinition {
return []*EnvVarDefinition{
// Version of the Chainloop Client
{"CHAINLOOP_DAGGER_CLIENT", false},
// Github Actions PR-specific variables (optional - only present in PR contexts)
{"GITHUB_EVENT_NAME", true},
{"GITHUB_HEAD_REF", true},
{"GITHUB_BASE_REF", true},
{"GITHUB_EVENT_PATH", true},
// Gitlab CI MR-specific variables (optional - only present in MR contexts)
{"CI_PIPELINE_SOURCE", true},
{"CI_MERGE_REQUEST_IID", true},
{"CI_MERGE_REQUEST_TITLE", true},
{"CI_MERGE_REQUEST_DESCRIPTION", true},
{"CI_MERGE_REQUEST_SOURCE_BRANCH_NAME", true},
{"CI_MERGE_REQUEST_TARGET_BRANCH_NAME", true},
{"CI_MERGE_REQUEST_PROJECT_URL", true},
{"GITLAB_USER_LOGIN", true},
}
}

Expand Down
23 changes: 20 additions & 3 deletions pkg/attestation/crafter/runners/daggerpipeline_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2024 The Chainloop Authors.
// Copyright 2024-2026 The Chainloop Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -62,13 +62,30 @@ func (s *daggerPipelineSuite) TestCheckEnv() {
}

func (s *daggerPipelineSuite) TestListEnvVars() {
assert.Equal(s.T(), []*EnvVarDefinition{{"CHAINLOOP_DAGGER_CLIENT", false}}, s.runner.ListEnvVars())
expected := []*EnvVarDefinition{
{"CHAINLOOP_DAGGER_CLIENT", false},
// Github Actions PR-specific variables
{"GITHUB_EVENT_NAME", true},
{"GITHUB_HEAD_REF", true},
{"GITHUB_BASE_REF", true},
{"GITHUB_EVENT_PATH", true},
// Gitlab CI MR-specific variables
{"CI_PIPELINE_SOURCE", true},
{"CI_MERGE_REQUEST_IID", true},
{"CI_MERGE_REQUEST_TITLE", true},
{"CI_MERGE_REQUEST_DESCRIPTION", true},
{"CI_MERGE_REQUEST_SOURCE_BRANCH_NAME", true},
{"CI_MERGE_REQUEST_TARGET_BRANCH_NAME", true},
{"CI_MERGE_REQUEST_PROJECT_URL", true},
{"GITLAB_USER_LOGIN", true},
}
assert.Equal(s.T(), expected, s.runner.ListEnvVars())
}

func (s *daggerPipelineSuite) TestResolveEnvVars() {
resolvedEnvVars, errors := s.runner.ResolveEnvVars()
s.Empty(errors)
s.Equal(map[string]string{"CHAINLOOP_DAGGER_CLIENT": "v0.6.0"}, resolvedEnvVars)
s.Equal("v0.6.0", resolvedEnvVars["CHAINLOOP_DAGGER_CLIENT"])
}

func (s *daggerPipelineSuite) TestRunURI() {
Expand Down
Loading