Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
7c402fc to
635a21c
Compare
cf-reactor can now read agent and reactor bundles, and updates them periodically ticket: ENT-14463 Signed-off-by: Victor Moene <victor.moene@northern.tech>
cf-reactor can now read policy from a specific input file Signed-off-by: Victor Moene <victor.moene@northern.tech>
635a21c to
4817594
Compare
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
A few naming questions is all really.
| bool reload_policy = false; | ||
| if (config->agent_specific.daemon.last_validated_at < validated_at) | ||
| { | ||
| Log(LOG_LEVEL_VERBOSE, "New promises detected, reloading policy"); |
There was a problem hiding this comment.
Here you are checking only reactor bundles? It seems "new promises detected" is a bit vague? Maybe "reactor bundle changes detected"?
|
|
||
| if (!reload_policy) | ||
| { | ||
| Log(LOG_LEVEL_DEBUG, "No new promises found"); |
There was a problem hiding this comment.
maybe "No policy changes seen by cf-reactor" or just leave the message out entirely?
|
|
||
| if (!GenericAgentArePromisesValid(config)) | ||
| { | ||
| Log(LOG_LEVEL_INFO, "Reactor policy has errors, keeping the previous policy"); |
There was a problem hiding this comment.
Here and further down, when you mention "Reactor policy" do you really mean reactor policy configuration aka "body reactor control"? It might be helpful to mention that more specifically.
There was a problem hiding this comment.
If you referred to code in agent, execd, monitord doesn't mention this as specifically I think we could change those messages also in a different ticket/PR.
3 participants
No description provided.