Skip to content

cf-check: Fix segfault on missing state directory #6359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btriller wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −0
Open

cf-check: Fix segfault on missing state directory #6359

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e7d1ee
cf-check: Fix segfault on missing state directory
btriller Sep 21, 2026
3c3b10d
Revert "cf-check: Fix segfault on missing state directory"
btriller Sep 22, 2026
ecbbc24
cf-check/dump: Log missing database files
btriller Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cf-check/dump.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,12 @@ int dump_main(int argc, const char *const *const argv)
}

Seq *files = argv_to_lmdb_files(argc, argv, offset);
if (files == NULL || SeqLength(files) == 0)
{
printf("No database files to dump.\n");
return 1;
}
Comment on lines +559 to +563

@larsewi larsewi Sep 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argv_to_lmdb_files already logs an error. Hence, there is no need to log another one here.

Suggested change
if (files == NULL || SeqLength(files) == 0)
{
printf("No database files to dump.\n");
return 1;
}
if (files == NULL || SeqLength(files) == 0)
{
return 1;
}


const int ret = dump_dbs(files, mode, tskey_filename);
SeqDestroy(files);
return ret;
Expand Down
Loading