ENT-13720: Install smtp-sink in valgrind check container#6136
Merged
Conversation
cf-execd's MailResult connects to localhost:25 whenever a cf-agent run produces output. Without an SMTP listener it logs "error: Mail report: couldn't connect to host 'localhost'" which check_daemon_output then catches as a test failure (flaky depending on whether cf-agent completes a run within the test window). Install postfix in the container for smtp-sink and run it on 127.0.0.1:25 before the daemons start. cf-execd's mail code path now gets exercised under valgrind instead of silently aborted. Ticket: ENT-13720 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
craigcomstock
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf-execd's
MailResultconnects tolocalhost:25whenever a cf-agent run produces output. The valgrind check container had no SMTP listener, so cf-execd loggederror: Mail report: couldn't connect to host 'localhost'andcheck_daemon_outputcaught it as a test failure. This was timing-dependent — it only surfaced when cf-agent completed a run within the test window.Install postfix in the container for
smtp-sink, and run it on127.0.0.1:25before the daemons start. cf-execd's mail code path now gets exercised under valgrind instead of silently failing on connect.