Skip to content

CFE-4628: Fixed a driver-assertion in get_by_name/get_by_uuid when attempting destroy --all whilst they are already destroyed in the cloud - #204

Merged
SimonThalvorsen merged 2 commits into
cfengine:masterfrom
SimonThalvorsen:CFE-4628
Sep 21, 2026
Merged

SimonThalvorsen merged 2 commits into
cfengine:masterfrom
SimonThalvorsen:CFE-4628

Conversation

@SimonThalvorsen

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.47%. Comparing base (c3b41ce) to head (ca8d758).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   49.09%   49.47%   +0.37%     
==========================================
  Files          18       18              
  Lines        3214     3214              
==========================================
+ Hits         1578     1590      +12     
+ Misses       1636     1624      -12     
Files with missing lines Coverage Δ
cf_remote/spawn.py 39.28% <100.00%> (+2.38%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SimonThalvorsen
SimonThalvorsen force-pushed the CFE-4628 branch 5 times, most recently from f31522c to 627b289 Compare September 14, 2026 16:44
@olehermanse

Copy link
Copy Markdown
Member

Needs manual testing

Ticket: None
Changelog: None

Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
…not in cloud)

Ticket: CFE-4628

Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
@SimonThalvorsen

Copy link
Copy Markdown
Contributor Author

Unable to reproduce the error, assumption is that when Lars tested it that there were no instances running and the list_drivers-method returned an empty list -> evaluated to True and the assert driver-check triggered. This should only happen if no argument is passed, in the case of empty nodelist then it should just iterate over nothing since there are no nodes to match. driver.list_nodes should only run if the node-list is not supplied, not if it is empty.

@SimonThalvorsen
SimonThalvorsen requested review from olehermanse and victormlg and removed request for victormlg September 18, 2026 17:22
@SimonThalvorsen
SimonThalvorsen merged commit 93a2806 into cfengine:master Sep 21, 2026
13 checks passed
@SimonThalvorsen
SimonThalvorsen deleted the CFE-4628 branch September 21, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants