ENT-13005: Added integrity check to cf-remote remote installation

[victormlg]

No description provided.

[larsewi]

Remember to test the script 😉

[larsewi]

Most of these checks can be done before you actually download the file. Maybe do these checks first, and then download.

[olehermanse]

Please expand nt-discovery.sh and then do the error checking as early as possible (as fast as possible). This way you can detect errors right after running nt-discovery.sh, without having to transfer over another script.

[larsewi]

This code preferred curl. Why is wget preferred now?

[victormlg]

This is intended in the ticket https://northerntech.atlassian.net/browse/ENT-13005

[olehermanse]

I don't think that's right, the ticket says;

Download with wget if that is available and curl is not

[victormlg]

In the initial PR I made it used curl as the default, but then changed it to wget after correction. What I mean that I changed it because it should be like it is now

[larsewi]

Consider using shlex.quote() on the passed arguments when building the shell commands in cf-remote. You could argue that if you can connect to a remote machine as root, then shell injection is not really a problem. But still it's good hygiene.

[victormlg]

Consider using shlex.quote() on the passed arguments when building the shell commands in cf-remote. You could argue that if you can connect to a remote machine as root, then shell injection is not really a problem. But still it's good hygiene.

The commands are already manually escaped inside ssh_cmd and ssh_sudo. So adding one more layer of quoting with shlex breaks the remote command. I think it would make sense to add this in a separate PR, and handle everything in the ssh functions.

[larsewi]

Thanks 🚀