Fixed build host setup failing when journal has no errors - #2509
Merged
Merged
Conversation
cleanup() runs under set -e, so the journalctl grep failed the build when it found no matching lines. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14689/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14689/ |
aleksandrychev
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup() in ci/setup-cfengine-build-host.sh runs under set -e. When the journal has no lines matching error|fail, the journalctl grep exits 1 and fails the build.
This broke testing-pr on legion7-redhat-8-x64-j1 in all nightlies on 2026-09-22, e.g. https://ci.cfengine.com/job/testing-pr/label=PACKAGES_x86_64_linux_redhat_8/3723/console
🤖 Generated with Claude Code