Repository navigation
Fix missing pattern in .github manifest exclusion - #451
Open
Robolightning wants to merge 1 commit into
Open
Robolightning wants to merge 1 commit into
Robolightning wants to merge 1 commit into
Conversation
sigmavirus24
approved these changes
Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
recursive-exclude .githubdirective has no file pattern, so setuptoolsreports
'recursive-exclude' expects <dir> <pattern1> <pattern2> ...and ignoresthat directive when building the sdist. Add
*to exclude the directory's filesas intended.
Validation with CPython 3.15.0 free-threading and setuptools 84.2.1:
FileList.process_template_lineraises
DistutilsTemplateError; the corrected rule excludes a sample.github/workflows/ci.ymland preservescertifi/core.py.python -m build --sdist --wheel --no-isolationsucceeds before and after;the malformed-rule warning disappears after the change.
sdist retains
cacert.pemandpy.typedand contains no.githubfiles.python -W error -m pytest: 3 passed.This corrects a manifest warning and its ineffective exclusion; it does not
claim that the unmodified current release fails to build.
CI status: mypy and all Python 3.7–3.15 jobs pass. The
3.16-dev job
uses Python 3.16.0a2 and stops while importing pytest, before collecting any
certifi tests: pytest imports
typing.AnyStr, whose new deprecation warningbecomes an error under
-W error. The latest successfulmaster job
used Python 3.16.0a1 with pytest 9.2.0. I have left the workflow and its strict
warning policy unchanged.