Skip to content

feat: add make target to upload SBOMs to GitHub releases - #723

Open
amarkdotdev wants to merge 2 commits into
cert-manager:mainfrom
amarkdotdev:feat/publish-sboms-154
Open

feat: add make target to upload SBOMs to GitHub releases#723
amarkdotdev wants to merge 2 commits into
cert-manager:mainfrom
amarkdotdev:feat/publish-sboms-154

Conversation

@amarkdotdev

Copy link
Copy Markdown

Summary

  • Add oci-upload-sbom-% make target to publish SPDX SBOMs from oci-build to GitHub releases

Fixes #154

Test plan

  • Verified makefile target syntax

Fixes cert-manager#154

Signed-off-by: Aaron <amark@g.jct.ac.il>
@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Aug 30, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign erikgb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2026
@erikgb
erikgb requested a lite review from Copilot August 30, 2026 09:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new publish-time Make target to upload SPDX SBOM artifacts produced by oci-build into the corresponding GitHub Release, addressing the gap noted in #154 for release SBOM availability.

Changes:

  • Introduces oci-upload-sbom-% targets derived from push_names.
  • Implements gh release upload logic to publish *.spdx.json files from the OCI layout .sbom directory to the current release tag.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread modules/oci-publish/01_mod.mk
Signed-off-by: Aaron <amark@g.jct.ac.il>
@amarkdotdev

Copy link
Copy Markdown
Author

Would appreciate a maintainer look when folks have a slot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish SBOMs

2 participants