-
Notifications
You must be signed in to change notification settings - Fork 2
Changes to make it easier for new developers to come onboard, changes to environment.prod.ts and service library CRUD pages #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scdsilva
wants to merge
23
commits into
cerberustesting:master
Choose a base branch
from
apspestana:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, because I was having the error "npm ERR! Invalid version: "0.1-SNAPSHOT"" when running "npm link" (which I needed to run because of error "You seem to not be depending on "@angular/core" and/or "rxjs". This is an error." when runnning "ng serve"),
…r for new developers to get up and running.
…l/register and @babel/compat-data so that the command "ng build --prod" executes successfully. Before updating the version of the specified dependencies, the build command ended with error "An unhandled exception occurred: Cannot find module '/Users/apestana/src/cerberus-angular/node_modules/@babel/compat-data/data/corejs3-shipped-proposals' See "/private/var/folders/dl/_bm9khtn3t956m6_z1nrl3t40000gn/T/ng-s7qnVD/angular-errors.log" for further details.".
…t (as implemented by BD) to replace specific configuration values (instead of a value we now have a placeholder, for the deployment script to search for the placeholder and replace it with a value).
…hanged the filter service to handle systems
…edit. Added changes to only show fields based on the type and method selected.
…t data and toFormData format. Duplicated names error is now handled by the server
…d the multi selection on services list. Added html format code on tooltip. Added some refactorings.
… edit functionality
…reset and save user preferences. Loaded preferences from the current structure and parse to the angular app one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make it easier for new developers to come onboard:
Changes to make it easier for new developers to come onboard and changes to environment.prod.ts to make it safer for the current deployment script to replace specific configuration values
Also, changed environment.prod.ts to make it safer for the deployment script (as implemented by BD) to replace specific configuration values (instead of a value we now have a placeholder, for the deployment script to search for the placeholder and replace it with a value).
Service library migration
-- Get services by current user systems
-- Filter, sort, search
-- Load and save persistently (API) the datatable preferences (with filters, search, sort)
-- Get invariants needed and application list
-- Switch fields display, based on the selected type and method