Repository navigation
Request smuggling / desync framing check - #28
Merged
Merged
Conversation
emmanuelgautier
force-pushed
the
feat/request-smuggling
branch
from
November 9, 2026 23:54
78d8a8b to
029d023
Compare
emmanuelgautier
force-pushed
the
feat/request-smuggling
branch
from
November 9, 2026 23:59
029d023 to
144cf57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10.
Adds
smuggling.ambiguous_framing, an aggressive-suite check (runs only with--aggressive) that tests the precondition for every classic request-smuggling attack: whether the proxy rejects RFC 9112-violating ambiguous message framing. Introduces a raw sender (smugprobe) since net/http sanitizes malformed framing before it reaches the wire.It sends four framings and flags any the proxy accepts (2xx/3xx) instead of rejecting (4xx/5xx or dropped connection):
Content-Length(CL.CL)Content-Length+Transfer-Encoding: chunked(CL.TE / TE.CL)Transfer-Encodingwith a non-chunked final encoding (TE.TE)Transfer-Encoding : chunked)Non-destructive: only benign, bounded, self-contained bodies, each on its own
Connection: closesocket. It never attempts the actual desync (which could poison another client's connection) — it reports purely on accept-vs-reject.Checklist coverage
Deferred items are documented in
docs/checks/smuggling.mdx. Includes registration and a category test (permissive vs. strict raw-server stand-ins).