Skip to content

Support cross-type numeric equality in verifier #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support cross-type numeric equality in verifier #1124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions verifier/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,16 +229,6 @@ public class PolicyVerifierExample {

### Limitations

* **Cross-Type Numeric Comparisons:**
* **Equality (`==`, `!=`):** Equality comparisons between different
numeric types (e.g., `int` vs `double` or `uint` vs `double`) are
currently not supported and will evaluate to `false` during
verification, even if they have the same mathematical value (e.g.,
`dyn(1) == dyn(1.0)` is false). Note that `int` vs `uint` equality *is*
supported.
* **Relational Operators (`<`, `>`, `<=`, `>=`):** Cross-type relational
comparisons are fully supported mathematically across all numeric
combinations (`int`, `uint`, and `double`).
* **Unsupported Standard Functions (Uninterpreted Functions):** Not all
CEL standard library functions have SMT axioms defined yet. Unsupported
functions are treated as *uninterpreted functions* by Z3 (the solver
Expand Down
2 changes: 1 addition & 1 deletion verifier/src/main/java/dev/cel/verifier/CelAstToZ3Translator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ private TranslatedValue translateSelect(CelExpr celExpr, CelAbstractSyntaxTree a
typeConstraints.add(createTypeConstraint(fieldAccess, exprId, ast));

return TranslatedValue.propagateStrict(
ctx, typeSystem, fieldAccess, celExpr, Arrays.asList(operandTv));
ctx, typeSystem, fieldAccess, celExpr, ImmutableList.of(operandTv));
}

private TranslatedValue translateBlock(
Expand Down
Loading
Loading