Bound prefix and suffix cost estimates - #1531
Open
iholder101 wants to merge 2 commits into
Open
iholder101 wants to merge 2 commits into
iholder101 wants to merge 2 commits into
Conversation
Verify static prefix and suffix estimates stay bounded by a short receiver. Assisted-by: Codex <noreply@anthropic.com> Signed-off-by: Itamar Holder <iholder@redhat.com>
Use the shorter operand in startsWith and endsWith estimates so an oversized argument cannot inflate static CEL cost checks. Assisted-by: Codex <noreply@anthropic.com> Signed-off-by: Itamar Holder <iholder@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the shorter of the receiver and argument when estimating
startsWithandendsWith. This prevents overestimating when the argument is longer than the receiver.Adds regression tests for both functions and runtime tracking. Validated with
go test ./common/cost.Fixes #1530.