Carry result sizes and selector paths through optional operations - #1525
Open
TristonianJones wants to merge 1 commit into
Open
TristonianJones wants to merge 1 commit into
TristonianJones wants to merge 1 commit into
Conversation
An estimate that passed through an optional previously lost the size of the wrapped value, leaving downstream estimates unbounded: - optional.of, optional.ofNonZeroValue, and optional.value were unmodeled, and optional.or and optional.orValue reported no result size, so a wrapped value's size did not survive the round trip. - Optional index overloads (_[?_]) recorded no field path, so @Items and @values size hints were not consulted below l[?0] or m[?'k']. Both are corrected at cost model version 1 while preserving legacy estimates when pinned to version 0. Also documents model revisions in docs/cost-model.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An estimate that passed through an optional previously lost the size of the wrapped value, leaving downstream estimates unbounded:
Both are corrected at cost model version 1 while preserving legacy estimates when pinned to version 0. Also documents model revisions in docs/cost-model.md.