Make ElemOf/KeyOf value-backed with model validation - #1519
Merged
Merged
Conversation
…tor metadata ElemOf and KeyOf previously reported placeholder sizes at runtime tracking time (0 and 1), so a model whose cost depends on what a container holds was charged as if it held nothing. TrackContext gains ArgVal, TargetVal, and ResultVal, and the projections inspect the runtime values: ElemOf and KeyOf report the largest element or key, matching the Max the estimate reports, and ElemTotal reports the exact combined element size. Because projections are only defined over expressions that denote a value, OverloadModel.Validate rejects projections applied to computed quantities at cel.CostModel registration time. Also updates SizeEstimate.Multiply, minExpr, maxExpr, and rangedExpr to carry the union of their operands' Key and Elem metadata, and clears Key metadata on listExpr so a list derived from a map operand does not retain the map's Key.
dmitriplotnikov
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElemOf and KeyOf previously reported placeholder sizes at runtime tracking time (0 and 1), so a model whose cost depends on what a container holds was charged as if it held nothing.
TrackContext gains ArgVal, TargetVal, and ResultVal, and the projections inspect the runtime values: ElemOf and KeyOf report the largest element or key, matching the Max the estimate reports, and ElemTotal reports the exact combined element size.
Because projections are only defined over expressions that denote a value, OverloadModel.Validate rejects projections applied to computed quantities at cel.CostModel registration time.
Also updates SizeEstimate.Multiply, minExpr, maxExpr, and rangedExpr to carry the union of their operands' Key and Elem metadata, and clears Key metadata on listExpr so a list derived from a map operand does not retain the map's Key.