Repository navigation
Fix beard invisible in States camera: frame compositing was commented out - #417
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause found in
status-camera-effects.js: a literal\\nsequence was inserted after a//comment, socompositeBeardForCapture()remained on the same JS source line and was commented out. The GPU output therefore never reached the visible camera canvas. Replace escaped characters with a real newline and add a regression assertion. Syntax checked via JS parser. Android visual test still needed; this fixes a definite integration blocker but does not certify WebGL mesh quality.