fix: refactor settings rendering into settingsgradle - #476
Merged
cdsap merged 1 commit intoSep 17, 2026
Merged
Conversation
cdsap
deleted the
issue/475-hermes-refactor-settings-rendering-into-set-a1
branch
September 17, 2026 19:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
ProjectWriter.kt:88-105 both assembles Gradle include syntax and writes settings files. SettingsGradle.kt already owns settings-file rendering, creating a split boundary and coupling file orchestration to Gradle syntax.
Why this matters
The settings format is harder to unit-test independently, and future changes can require modifying both the writer and root-project generator.
Proposed change
Move module include rendering into SettingsGradle, passing mapped module paths or module data from ProjectWriter. Keep ProjectWriter responsible only for writing the resulting content to each language-specific settings file.
Notes
This keeps root-project document generation in the generator layer and leaves filesystem writes in the writer layer, clarifying the infrastructure boundary without introducing a broader architectural change.
Fixes #475
Changes
project-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/rootproject/SettingsGradle.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/writer/ProjectWriter.ktproject-generator/src/test/kotlin/io/github/cdsap/projectgenerator/generator/rootproject/SettingsGradleTest.ktVerification
./gradlew :project-generator:unitTest./gradlew :cli:test./gradlew ktlintCheck