Repository navigation
Release converted attribute aliases after deleting keys - #343
Open
gary1110086 wants to merge 1 commit into
Open
gary1110086 wants to merge 1 commit into
gary1110086 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a key leaves its converted attribute name reserved. With
box_duplicates="error", deleting"a b"and then inserting"a-b"raises a duplicate error even though the Box is empty.Release the alias when its owning key is removed. Cover item and attribute deletion,
pop,popitem, and colliding keys, including aNonekey. Add the required CHANGES and AUTHORS entries.Validation on Windows / Python 3.12: 166 tests pass with both the Python and compiled Cython implementations; mypy passes.