-
Notifications
You must be signed in to change notification settings - Fork 181
Direct mount without fusermount #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vociferix
wants to merge
20
commits into
cberner:master
Choose a base branch
from
Vociferix:direct-mount
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
11a0fa3
implemented direct mounting without libfuse or fusermount
Vociferix e56eaac
fixed mount options in fuse_direct.rs
Vociferix 7b8c00f
Merge branch 'master' into direct-mount
Vociferix dd452af
Merge branch 'master' into direct-mount
Vociferix 7c45654
implemented 'should_auto_unmount' and fixed 'NoAtime' option handling
Vociferix 12dadcf
refactor direct-mount option handling to reuse functions from pure-ru…
Vociferix 37bf52f
added direct-mount tests to Linux and BSD suites
Vociferix 0e29072
Merge branch 'master' into direct-mount
Vociferix 8d92cf8
fixed typo'd tests
Vociferix 07c9af4
removed unneeded #[cfg()] on mount option utilities
Vociferix 2bc26aa
direct-mount implementation for FreeBSD
Vociferix 2de658c
fixed macos and freebsd lints
Vociferix 15909d2
cleanup and fixed a few mistakes/oversights
Vociferix c7fbf54
implemented BSD specific version of MountImpl::should_auto_unmount
Vociferix fd307d2
small correction to direct-mount linux test cases
Vociferix a176799
updated direct-mount MountImpl::unmount_impl to properly check if the…
Vociferix 608fa07
Merge branch 'master' into direct-mount
Vociferix 0f4f455
direct-mount waits for auto unmount daemon on unmount, and changed to…
Vociferix 4ce1d62
CI bump
Vociferix 35ab821
CI bump
Vociferix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test path is meant to validate “no
fusermountdependency” fordirect-mount, but it passeslibfuse.fusermount()(which may allowfusermountto be present/used depending on the harness). To specifically cover the new requirement, run the auto-unmount direct-mount test withFusermount::Falseso the test proves it works withoutfusermountavailable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see
libfuse.fusermount(). I think that's what Codex is saying should be removedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I missed one. Fixed