Feat/dns force warning - #37
Merged
Merged
Conversation
UpsertCNAME already refused to touch a DNS record it didn't create unless --force was passed, but once --force *was* passed, the delete happened silently — no output named what was removed or what it used to point to. UpsertCNAME now returns the deleted record (type + content) whenever it was a foreign one, and 'zt up'/'zt apply' (which both funnel through createTunnel) print an explicit warning with those details right where the DNS step already reports success. This is a printed warning, not a blocking confirmation prompt — same call made for --public's exposure warning a couple rounds back: an interactive prompt would break the CI-driven PR-preview workflow (cfzt-action calls 'zt up' non-interactively). Anyone relying on --force in automation should treat this warning line as something to grep their run logs for, not something they'll see live.
Covers all four branches merged this sprint: tunnel-name-validation, init-hidden-token, env-api-token, tunnel-ownership-tag, plus this branch's DNS force-delete warning. Bump the version and tag the release separately, as usual.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.