Minor changes in response to 2026-02-25 course run#42
Conversation
* rename columns (b/c talking about “the horizontal column” is awkward) * add explanation to solution (and highlight similarity to pythagoras function) * minor import cleanup
* explicit exception handling to avoid printing full stacktrace in case of network issues * use with statement instead of manual thread pool cleansup
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/pando-python/compare/md-outputs..md-outputs-PR-42 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-03-17 12:58:13 +0000 |
Robadob
left a comment
There was a problem hiding this comment.
I'm happy with this in principle.
Do let me know if you would like me to write a longer summary of the model (and ABM), it wouldn't be too difficult to draft, though it will probably end up being several hundred words.
|
I think several hundred words of explanation in the main text would be too much. But a slightly longer summary of the model, to help people looking at the code get an overview over the structure, could be good as a module-level docstring in That’s independent of this PR, though; so I’ll merge this one now. Thanks for the review! |
Auto-generated via `{sandpaper}`
Source : 27dd896
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-03-17 13:04:59 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : a66b678
Branch : main
Author : Jost Migenda <jost.migenda@kcl.ac.uk>
Time : 2026-03-17 13:02:51 +0000
Message : Merge pull request #42 from JostMigenda/JostMigenda/20260225_feedback
Minor changes in response to 2026-02-25 course run
Thanks, I'll add it to my private todo list and hopefully find time before next week. |
Resolves several points mentioned in #40. In particular:
Added examples of agent-based models in various disciplines, to illustrate relevance of predprey model.
Done; and explained why
np.sqrt()is preferable.Done.
Improved exception handling so network glitches don’t lead to printing a full stack trace any more. Should now cause much less of an adrenaline spike if the demo fails; so I think this is okay.