Eo 26922 bindable roots in controller expressions

[ccpHenry]

Summary: Controller expressions can now read float attributes straight from bound objects using path syntax in the expression field ( for example Owner.translation.x or SpaceObjectParent.someAttr )

the problem before this:
right now when artists need to use attribute variables in controllers the go-to methood is sto bind it into one of the variables. This is a bit problematic as often that variable is only needed once or only in certain controller subsections.
Another problem is that getting variables from above the level where the controller sits it requires a lot of extra effort and another controller on a higher level to pass that variable down.
This change attempts to fix both problems at once by making it so variables can be fetched on demand and up the tree

some notes:

• If a root isn't attached yet, its references stay pending and get resolved lazily. They evaluate to 0 until they resolve. (spawned in effectChildren etc)
• When parsing an expression, Tr2ControllerExpression looks for paths that start with a known root. Each one becomes a Tr2BindingPoint.
• A path that can't be bound gives the error cannot bind "" to a float attribute.
  Owner and SpaceObjectParent now appear under a new "Bindings" group in the expression term info, so artists can have some help remembering this feature

img of an example use:

[github-actions]

Cpp-linter Review

Used clang-format v21.1.8

Click here for the full clang-format patch

diff --git a/trinity/Controllers/ITr2Controller.h b/trinity/Controllers/ITr2Controller.h
index 422a834..85822ae 100644
--- a/trinity/Controllers/ITr2Controller.h
+++ b/trinity/Controllers/ITr2Controller.h
@@ -56 +56 @@ BLUE_INTERFACE( ITr2Controller ) :
-void UpdateSpaceObjectParentRoot( std::vector<std::pair<std::string, IRoot*>> & roots, IRoot * owner );
+void UpdateSpaceObjectParentRoot( std::vector<std::pair<std::string, IRoot*>>& roots, IRoot* owner );

Have any feedback or feature suggestions? Share it here.

outdated suggestion

[github-actions]

Cpp-linter Review

Used clang-format v21.1.8

Click here for the full clang-format patch

diff --git a/trinity/Controllers/ITr2Controller.h b/trinity/Controllers/ITr2Controller.h
index 422a834..85822ae 100644
--- a/trinity/Controllers/ITr2Controller.h
+++ b/trinity/Controllers/ITr2Controller.h
@@ -56 +56 @@ BLUE_INTERFACE( ITr2Controller ) :
-void UpdateSpaceObjectParentRoot( std::vector<std::pair<std::string, IRoot*>> & roots, IRoot * owner );
+void UpdateSpaceObjectParentRoot( std::vector<std::pair<std::string, IRoot*>>& roots, IRoot* owner );

Have any feedback or feature suggestions? Share it here.

[Copilot]

Copilot review overview

🟡 Changes recommended

Reference handling introduces undefined pointer arithmetic, naming collisions, stale dynamic bindings, and misleading diagnostics.

Review effort: Balanced
Findings: 1

Open (1)

• Undefined pointer subtraction across variable view arrays · New

What changed in this PR

Adds bindable object-root paths to controller expressions, including owner and space-object-parent attributes.

Changes:

• Rewrites binding paths into parser variables evaluated through Tr2BindingPoint.
• Adds dynamic Owner and SpaceObjectParent roots.
• Extends binding-path parsing and validity checks.

File	Description
Tr2TimelineController.cpp	Exposes binding roots and expression metadata.
Tr2ControllerExpression.h	Defines reference-binding state.
Tr2ControllerExpression.cpp	Rewrites, binds, and evaluates references.
Tr2Controller.cpp	Resolves space-object-parent roots.
Tr2BindingPoint.h	Exposes path matching.
Tr2BindingPoint.cpp	Improves path parsing and binding validity.
ITr2Controller.h	Declares the root-update helper.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

outdated suggestion