Repository navigation
Release 0.5.0: @abap2ui5/node-runtime 1.147.0, the express adapter found in either output layout - #107
Merged
Conversation
…und in either output layout The plugin pins the published runtime at 1.147.0 (abap2UI5 1.147.0, tagged 2026-10-14). That release's output/ is a folder per origin (@abaplint/transpiler 2.14), and locate( ) named the adapter by the flat path - the conformance host died on the import with ERR_MODULE_NOT_FOUND in the nightly run against upstream main (38419982897). shimPath( ) takes output/express-icf-shim/ first and the flat output/ of 1.146.0 and older second, so an `overrides` to an older runtime still boots, and a package with neither says so instead of failing on the import. The nightly's other failure, "the framework's 500 does not reflect the client's url", was the same mismatch from the other side: runtime/ held 1.147.0 while the plugin's nested node_modules kept the pinned 1.146.0, which predates the core fix. With 1.147.0 resolved everywhere the test passes; lint and the 222 bookshop tests are green here. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TrfF51pia7m6tLZQF2G2ua
…ne has it The stand-ins symlink the real runtime's output/ and hard-coded the flat shim path, which the 1.147.0 layout (output/express-icf-shim/) does not have; the seven tests died on the import. The path is taken from what locate( ) found, so the fixture follows either layout. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TrfF51pia7m6tLZQF2G2ua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release PR for 0.5.0, per AGENTS.md "Releasing":
plugin/package.jsonmoves to 0.5.0 and pins the published@abap2ui5/node-runtimeat 1.147.0 (abap2UI5 1.147.0, tagged 2026-10-14); theUnreleasedlines ofplugin/CHANGELOG.mdmove under[0.5.0], with a line for the runtime.Two things the nightly run against upstream main found (38419982897), both from that runtime:
output/is a folder per origin (@abaplint/transpiler2.14), andlocate( )named the express adapter by the flat path - the conformance host died on the import withERR_MODULE_NOT_FOUND.shimPath( )takesoutput/express-icf-shim/first and the flatoutput/of 1.146.0 and older second, so anoverridesto an older runtime still boots, and a package with neither says so instead of failing on the import. The accelerate test's stand-ins hard-coded the flat path too; they take it from whatlocate( )found.runtime/held 1.147.0 while the plugin's nestednode_moduleskept the pinned 1.146.0, which predates the core fix. With 1.147.0 resolved everywhere the test passes - the URL comes back stripped.Checked here on the published 1.147.0 (
scripts/assemble-runtime.sh --package 1.147.0):npm run lint,npm test(222 tests, 221 pass, 1 skipped: the MCP_SERVER_DIR one),npm run consumer-test(both tarballs packed and installed into a throwaway CAP project, the runtime that loads is 1.147.0, the roundtrips, abap2js and the agent endpoint answer).After the merge:
git tag v0.5.0 && git push origin v0.5.0-release.ymlfillsruntime/from the published 1.147.0, runs the suite andconsumer-teston the tag and publishes by trusted publishing. Then cap2UI5/samples#11 (peer range^0.5.0) can go out as 0.3.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01TrfF51pia7m6tLZQF2G2ua
Generated by Claude Code