Conversation
philippfromme
force-pushed
the
on-task-execution-error
branch
2 times, most recently
from
c53633c to
bb992e3
Compare
bpmn-io-tasks
bot
added
in progress
philippfromme
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philippfromme
force-pushed
the
on-task-execution-error
branch
from
bb992e3 to
76fa752
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philippfromme
force-pushed
the
on-task-execution-error
branch
from
76fa752 to
90f1603
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philippfromme
force-pushed
the
on-task-execution-error
branch
from
90f1603 to
bb08ac4
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| expect(onTaskExecutionFinished).to.have.been.calledOnce; | ||
| expect(onTaskExecutionFinished).to.have.been.calledWithMatch(elementRegistry.get('ServiceTask_3'), { | ||
| success: true | ||
| }); |
There was a problem hiding this comment.
Duplicate assertion on line 372 and 369-370. The assertion on line 372 is redundant since it's already verified in the waitFor block above.
- Unify callbacks into onTaskExecutionFinished with reason field - Remove onTaskExecutionInterrupted Result object now uses discriminated union: - success: true → contains variables - success: false → contains reason (incident/user.cancel/user.selectionChanged/error) BREAKING CHANGE: onTaskExecutionInterrupted removed. Use onTaskExecutionFinished with result.success and result.reason instead. Related to camunda/camunda-modeler#5597
philippfromme
force-pushed
the
on-task-execution-error
branch
from
bb08ac4 to
b9905c9
Compare
1 participant
Proposed Changes
Result object now uses discriminated union:
BREAKING CHANGE: onTaskExecutionInterrupted removed.
Use onTaskExecutionFinished with result.success and result.reason instead.
Related to camunda/camunda-modeler#5597
Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool