Skip to content

Comments

feat: add code folding#70

Draft
philippfromme wants to merge 1 commit intomainfrom
folding
Draft

feat: add code folding#70
philippfromme wants to merge 1 commit intomainfrom
folding

Conversation

@philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Feb 4, 2026

Proposed Changes

Adds cold folding. I didn't adjust the styling, it's the same styling as in the Desktop Modeler XML editor.

chrome_QXB97fqQJ2

Closes #71
Related to camunda/camunda-modeler#5598

Checklist

Ensure you provide everything we need to review your contribution:

  • Your contribution meets the definition of done
  • Any new additions or modifications are consistent with the existing UI and UX patterns
  • Pull request description establishes context:
    • Link to related issue(s), i.e. Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}
    • Brief textual description of the changes
    • Screenshots or short videos showing UI/UX changes
    • Steps to try out, i.e. using the @bpmn-io/sr tool

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 4, 2026
@philippfromme philippfromme requested a review from Copilot February 4, 2026 16:11
@philippfromme philippfromme marked this pull request as ready for review February 4, 2026 16:11
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 4, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds code folding functionality to the Output Editor to improve readability of large JSON outputs. The implementation uses CodeMirror's built-in folding features, including the fold gutter UI and keyboard shortcuts.

Changes:

  • Added code folding support to the Output Editor using CodeMirror's foldGutter and foldKeymap extensions
  • Imported necessary folding utilities from @codemirror/language and keymap from @codemirror/view

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@barmac
Copy link
Contributor

barmac commented Feb 4, 2026

We probably don't want to show the gutter for a deployment failure:
image

@barmac
Copy link
Contributor

barmac commented Feb 4, 2026

It looks OK on the happy path:
image

@barmac barmac assigned philippfromme and unassigned barmac Feb 5, 2026
Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix #70 (comment)

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Feb 5, 2026
@philippfromme philippfromme added the needs review Review pending label Feb 5, 2026 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Feb 5, 2026
@jarekdanielak
Copy link
Contributor

@philippfromme is this ready for a final review?

@barmac barmac added in progress Currently worked on and removed needs review Review pending labels Feb 10, 2026
@philippfromme philippfromme marked this pull request as draft February 19, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in progress Currently worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support code folding

3 participants