fix(nip45): return COUNT results for filters with generic tag queries - #775
Merged
Anshumancanrock merged 2 commits intoSep 14, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 6b47384 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
cameri
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
countByFiltersprojectedevents.event_idtwice for any filter carrying a generic tag query(
#e,#p,#g,#h): once on the builder it creates, and again in a tag branch copied fromfindByFilters(). The outercount(distinct event_id)then referenced a derived table with twocolumns of the same name, which Postgres rejects with
42702 column reference "event_id" is ambiguous. A COUNT mixing a tag filter with a non-tag one failed differently, leaving the UNIONbranches with unequal column counts.
This PR removes the second projection. The
event_tagsjoin fan-out isalready collapsed by the outer
countDistinct. Fixing the arity mismatch falls out of the samechange, since every branch now projects one column.
Add two regression tests
Related Issue
Closes #774
Motivation and Context
nip45.enableddefaults totrueand 45 is advertised insupportedNips, so a stock relayclaims COUNT support while failing the two queries COUNT is mostly used for:
{"kinds":[7],"#e": [...]}for reactions on an event, and{"kinds":[3],"#p":[...]}for follower counts. Both wereanswered with
["CLOSED", <id>, "error: unable to count events"].The existing
countByFilterstests stub.from(), so no SQL reaches a database and substringassertions pass on the broken query.