Repository navigation
test(repositories): make the user-subscription spec independent of the time zone - #1001
Merged
cameri merged 2 commits intoOct 29, 2026
Merged
Conversation
…e time zone Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
🦋 Changeset detectedLatest commit: 53b8ea6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
[Low impact] The PR appears safe to merge; no actionable issues were found.
|
Collaborator
Coverage Report for CI Build 40844125828Coverage increased (+0.006%) to 76.754%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
cameri
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
user-subscription-repository.spec.tsasserted that a literal like'2026-01-31appears in the generated SQL. The driver prints a date in the local time zone of the machine, so the literal only matched in UTC and to the east of it, and five tests failed anywhere west of it (the threefindDueForRenewal,findPeriodEndedandfindGraceEndedbounds, and the twoupdateIfCurrentIS NOT DISTINCT FROMclauses).The spec now prints the expected date the same way the driver does (
real.raw('?', [date])) and asserts on that, so it still checks that the exact instant it was given is the one in the statement. Only the spec changes.Related Issue
Closes #971
Screenshots (if appropriate):
Types of changes
Checklist: