Repository navigation
Port Obsidian plugin UI to shared Lingui kit - #2418
Merged
Merged
Conversation
Absorb all eight locale reviews, converter/codemods, compiled-pack runtime, and in-progress missing-copy remediation. Not release-ready: translations and audit/test migration remain incomplete; bundled size gate currently fails at 5,183,890 bytes.
Keep all nine locales synchronous and preserve uncompressed downloadable pack bytes. Bundle analysis versus e70b7ba: baseline 4,828,946; raw port 5,204,369; compact port 4,423,994 bytes. Focused catalogue/presentation tests pass. Full acceptance and translations remain pending.
Merged
callumalpass
changed the base branch from
feat/downloadable-language-packs
to
main
October 26, 2026 09:45
callumalpass
marked this pull request as ready for review
October 26, 2026 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lingui port — independent re-review N1–N9
Draft stacked on
feat/downloadable-language-packs(#2417); base and draft status unchanged. Head:b96d2b8cf242d4719964ba586b7a790d357ca436. Validated implementation/native harness:46c0752b833e761002d5cb8e1794387447660856; the final commit records evidence only.Findings
Authorship and policies
dcb21741. Direct original-translator comparison verifies 2,704 retained translations per target locale unchanged, including recovered text. No English target padding or newly authored translations in this round.S3yJwAis explicitly accounted for in es/fr, without allowing any corrected one arm to disappear.src/localesis unchanged.Current validation
9587bdf752e8b654fe6425e42eefd5b287ca835a89c8035ff238797b8fdf043c. No hosted checkout/setup/upload acceptance or OAuth-secret integration claim. The existing Node-20-only performance step remains skipped under Node 22.Current native desktop evidence
Three bundled minified-build tests pass on isolated Linux/Xvfb Obsidian 1.14.2:
The native run exposed Obsidian's icon-only empty-value representation. The group-label adapter now shares the existing classifier instead of guessing from user strings; a unit regression covers it. Final successful runs retain screenshot-bearing Playwright traces. Reports, artifact hashes and embedded en/de results are in
docs/development/i18n-rereview.json; local files are undertest-results/lingui-bundled/and the threelingui-bundled-*trace directories. No personal vault/profile was used; fixtures/settings were restored and fixture folders removed.Explicit limits
febb5f8905439a92196da119d901ead204755fb1, not claimed as rerun here; both current production build graphs/budgets pass.~/projectschanges.Evidence:
docs/development/i18n-rereview.json(current findings/source-bound validation/native report),i18n-acceptance.json,i18n-ci-workflow-parity.json. Historical plural/authorship/singleton inventories are retained and explicitly scoped; they are not regenerated as current migration ledgers.