Repository navigation
Align generated types with the published starter (rc.15) - #19
Merged
Merged
Conversation
- TASKNOTES_MDBASE_TYPE_VERSION (4) is the generated type version, equal to the published starter's, so types written by TaskNotes and by the pack agree. - assignees is never legacy-nullable: v0.2 collections cannot contain it, and a nullable variant conflicted with the starter on pack upgrade. - The starter publishes the first starter's generator bookkeeping unchanged (TASKNOTES_STARTER_MANAGED_FIELDS) and a starter revision (5); it reproduces tasknotes.task pack rc.17 byte for byte. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while preparing TaskNotes 5.0 upgrades, by running TaskNotes App approval (mdbase-rs, Connect's adoption retry) against collections written by TaskNotes 4.13.6 and the 5.0 betas and upgraded by the 5.0 release candidate:
version: 3, the published starter4; the pack's seed upgrade saw two different version changes and refused.TASKNOTES_MDBASE_TYPE_VERSION = 4is now used by the generator and the starter.assignees(not a v0.2 field) became nullable too and conflicted with the starter. It is nowlegacyNullable: false.x-tasknotes-generator.managed_fields(TASKNOTES_STARTER_MANAGED_FIELDS), since each collection's list follows its own field mapping; plusTASKNOTES_STARTER_REVISION = 5for the published file name. The starter reproduces pack rc.17 (TaskNotes rc.17: leave collections' generator bookkeeping alone mdbase-dev/mdbase-contracts#9) byte for byte; the test pins its digests.Package 0.3.0-rc.15 (rc.14 was never published).
🤖 Generated with Claude Code