Skip to content

fix(test): the daemon tests use the Windows endpoint and skip POSIX-only facts - #1728

Draft
V3RON wants to merge 12 commits into
task/1707from
task/1706
Draft

V3RON wants to merge 12 commits into
task/1707from
task/1706

Conversation

@V3RON

@V3RON V3RON commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1706

Status

Implement: done (build x2 + audit + 2 fix runs) Review: rounds 1, 2 + fix-check, 0 open Hardware: n/a Gate: waiting for the stack
Next: CI on db8cca9, then the stack gate

Assumptions

  • Assumption: removing a test directory that Windows still holds — a new src/test-support/remove-directory.ts retries EBUSY/EPERM for about 3 s, and the fleet test retries it again for up to 5 s, under the 10 s hook timeout — this is the smallest change that keeps the tests real instead of skipping them.
  • Assumption: two assertions that only hold on POSIX are guarded on process.platform rather than skipped (the uplink buffered-bytes check and the in-place mode check) — the rest of those tests still runs on Windows.
  • Assumption: the uplink redial test advances the fake clock on each try until the backoff timer fires — the worker's end can see the close after the gateway's, so the timer's arming time is not fixed.

Written by an agent.

…ketPath gives, and POSIX-mode tests skip on win32 (#1706)
@V3RON
V3RON added this pull request to stack #1724 November 18, 2026 16:01
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ports, daemon and the server-side modules pass their unit tests on Windows

1 participant