Skip to content

test(drivers): the iOS driver's and core's unit tests pass on Windows - #1726

Open
V3RON wants to merge 7 commits into
task/1706from
task/1708
Open

V3RON wants to merge 7 commits into
task/1706from
task/1708

Conversation

@V3RON

@V3RON V3RON commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1708

Status

Implement: done (build + audit) Review: round 1, 0 findings Hardware: n/a Gate: waiting for the stack
Next: the stack gate

Every file of src/drivers/ios/ and src/core/ is off the Windows list. The first run of 44344869970 failed in src/agent-device/ (gateway-front-lease-header, local-profile), outside this task; its re-run passed, so they are Windows flakes for #1709. A src/history test timed out in two earlier runs.

Assumptions

  • Assumption: src/core/instance-identity.test.ts "creates instance.json owner-only" — skipped on win32 (ADR 0087 section 3: Windows has no mode 0600), the conservative option; no product change was needed anywhere.

Done when

  • pnpm test:changed passes on the branch. — run by the build and the audit on e3e5a89; CI Unit tests green
  • The PR's Unit tests (Windows) job passes, and no file of the group is left in src/test-support/windows-skipped.ts. — Unit tests (Windows) green on e3e5a89 (run 44344869970, attempt 2); the 3 core and 25 iOS entries are gone (spec review checked)

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 8.3M.
Runs: 6. Cost USD: 4.7506. Agent seconds: 4877.

Assessment: complete

Written by an agent.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Core and iOS test fixtures now build paths with platform-aware utilities and shared path constants. Test helpers normalize paths for comparisons. The core permissions test skips on Windows, and two migration tests close reopened state databases after checking their assertions. The Windows skip list no longer includes the listed core and iOS tests.

Merge Risk: Minimal · up to 7ef54

This PR makes the iOS driver and core unit tests run on Windows and removes them from the skip list. It changes test code only, so production behavior is unaffected. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Objective [#1708, B6]: every file of src/drivers/ios/ and src/core/ passes on the Windows job and is off the list. Current PR contribution: the summary shows test-only changes to the group's test file… Provide evidence that the Windows unit-test job passes on the current head 7ef542a, or confirm that no test-file change exists between e3e5a89 and 7ef542a. Provide the actual diff of src/test-support/windows-skipped.ts against the base so t…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title names the main change: iOS driver and core unit tests were made to pass on Windows. The changeset removes these test files from the Windows skip list and adjusts path handling so the tests r…
Description check Passed The description relates directly to the changeset. It states that files under src/drivers/ios/ and src/core/ were removed from the Windows skip list, names the skipped owner-only instance.json test on…
Out of Scope Changes check Passed The changes listed in the summary fall within the issue scope. They are test files and test helpers in src/drivers/ios/ and src/core/, plus the removal of entries for those folders from src/test-suppo…
Full details: Title check

Explanation

The title names the main change: iOS driver and core unit tests were made to pass on Windows. The changeset removes these test files from the Windows skip list and adjusts path handling so the tests run on Windows. Its wording is specific enough for a teammate scanning history, and it does not describe anything absent from the changeset.

Full details: Description check

Explanation

The description relates directly to the changeset. It states that files under src/drivers/ios/ and src/core/ were removed from the Windows skip list, names the skipped owner-only instance.json test on win32, and reports the Windows unit-test job results. It also lists the status and review ledger, which is process detail but still tied to this change.

Full details: Out of Scope Changes check

Explanation

The changes listed in the summary fall within the issue scope. They are test files and test helpers in src/drivers/ios/ and src/core/, plus the removal of entries for those folders from src/test-support/windows-skipped.ts. The summary reports no product-code change. The win32 skip of one owner-only permission test in src/core/instance-identity.test.ts is a test-only change, justified in the PR by ADR 0087 section 3, and it is not an unrelated change. No file outside the issue scope is shown in the summary. The diff tool was unavailable, so the full changed-file list was taken from the supplied summary and not from a diff.

Full details: Linked Issues check

Explanation

Objective [#1708, B6]: every file of src/drivers/ios/ and src/core/ passes on the Windows job and is off the list. Current PR contribution: the summary shows test-only changes to the group's test files and helpers (path construction with node:path join/resolve, shared sourcesSetPath/unownedSourcesSet constants, POSIX normalization in test-slim.ts and test-index.ts, an explicit EBUSY-safe db close in registry.test.ts) and removal of 3 core and 24 iOS entries from WINDOWS_SKIPPED. The file at head 7ef542a contains no src/core or src/drivers/ios entries, so the list criterion is met at head. The pass evidence for the Windows job cites commit e3e5a89 (run 44344869970, attempt 2), not the current head 7ef542a. The changes since e3e5a89 are not verified as test-only and do not touch the Windows job result. The PR text states 25 iOS entries removed; the summary states 24. The diff tool was unavailable, so this count and the changed hunks could not be checked. Test-only skipping of owner-only instance.json on win32 is noted; the test file is in scope. Stack objective [#1708, B6] (Uncertain): #1703 (reviewed) adds ADR 0087 only and provides the Windows-job rule. #1722, #1727, #1728, #1729 and #1736 are uncertain and have no current review evidence, so their contribution to a passing Windows job cannot be established. #1705, which the issue depends on, is not in the supplied stack evidence. Stack status: Partially addressed for the list removal at head; pass evidence for the Windows job on the current head is missing.

Resolution

Provide evidence that the Windows unit-test job passes on the current head 7ef542a, or confirm that no test-file change exists between e3e5a89 and 7ef542a. Provide the actual diff of src/test-support/windows-skipped.ts against the base so the removed entry count can be checked. Provide review evidence for #1722, #1727, #1728, #1729 and #1736, and confirm the status of the #1705 dependency, so the stack objective can be assessed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: c227cd42-90d3-4353-bc94-0c8bbe5dd4a9
Commits

Reviewing files that changed from the base of the PR and between e3e5a89 and 7ef542a.

Files selected for processing: 1

  • src/test-support/windows-skipped.ts
Files with no reviewable changes: 1

  • src/test-support/windows-skipped.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

@V3RON

V3RON commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: e3e5a89

Runs: 6. Cost USD: 4.7506. Agent seconds: 4877.
Tokens input 280, output 63684, cache read 11014289, cache write 947746.
- build implementer: claude-sonnet-5-5 4020 s $2.7485
- audit implementer: claude-sonnet-5-5 306 s $0.1825
- review 1 reviewer: claude-sonnet-5-5 273 s $0.1366
- review 1 spec: claude-sonnet-5-5 27 s $0.1849
- review 1 code tests: claude-opus-5-5 217 s $1.2846
- review 1 claims: claude-sonnet-5-5 34 s $0.2135
Finding outcomes: {}. Classes: {}.
{"findings":[]}

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review November 18, 2026 16:35
@V3RON
V3RON changed the base branch from task/1705 to task/1706 November 18, 2026 16:35
@V3RON
V3RON added this pull request to stack #1724 November 18, 2026 16:35

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The iOS driver and core pass their unit tests on Windows

1 participant