Repository navigation
Description
Part of #1693.
Scope
With every group fixed, the list of files the Windows job leaves out, and the testing rule's exception for it, are deleted, and every file that other changes merged to main in the meantime broke on Windows is fixed here. #1712's task makes those fixes as commits on the branch of the lowest PR of the stack whose Windows job the break turns red, and the stack sync carries them up, so every PR's CI is green at the gate; one fix check reviews them, as for a slow-lane loop. The Windows job then runs every unit test file, as the Linux job does, and reaches main with the stack.
If it goes wrong, a file quietly stays out of the Windows run, the rule keeps an exception nobody needs, or the catch-up turns out larger than one PR.
Technical spec
Commit 2df19f8.
Rows
- Behaviours: B9
- Interfaces: I1 (deleted)
- Existing code: X3, X13
Facts
| # | Fact | Source |
|---|---|---|
| F1 | Other features' changes reach main with no Windows check until this stack merges, so files fixed by #1706 to #1710 can fail again at this task's head. |
#1693 Decisions (maintainer's choice, one stack); docs/internal/agent-rules/delivery.md:238-251 |
| F2 | The gate needs every PR of the stack green, and the stack sync merges each PR's parent into it from the bottom up. | .agents/scripts/merge-pr.sh:6-11, .agents/scripts/merge-pr.sh:148, .agents/scripts/stack-sync.sh:6-8 |
| F3 | Loop fixes may be commits on a PR's branch for code an earlier PR of the stack added, with one fix check after. | docs/internal/agent-rules/delivery.md:270-273 |
Modules touched
Searches: rg -n "windowsSkipped|WINDOWS_SKIPPED|windows-skipped" ..
- Any test file, or product code, a merge to
mainbroke on Windows, fixed by B4 to B8's cases for its folder. src/test-support/windows-skipped.ts(deleted),vitest.config.ts,src/test-lanes.repo.test.ts,src/test-support/AGENTS.mddocs/internal/agent-rules/testing.md,docs/internal/adr/0087-the-unit-tests-run-on-windows-in-ci-and-a-list-of-files-still-failing-there-only-shrinks.mdis not edited (its status follows the feature).
Rules in play
- ADR 0087 §4: the last task deletes the list and its exception.
docs/internal/agent-rules/testing.mdrule 5 keeps the POSIX-only sentence.
Tests
The seam is src/test-lanes.repo.test.ts.
- B9: every file passes on the Windows job at the stack's head, a file another feature broke fixed by its folder's cases;
src/test-support/windows-skipped.tsdoes not exist;vitest.config.tsgives theunitproject the same excludes on every host;testing.mdrule 5 holds no list exception
Done when
pnpm test:changedpasses on the branch.- The PR's
Unit tests (Windows)job passes with no file left out. - A person runs
pnpm test:unitfrom Git Bash on DesktopWindows (Windows 11, with Python 3 installed and the Store alias left on) at the PR's head, and the PR lists the summary lines it printed.
Out of scope
- The e2e lane on Windows.
Depends on
- Ports, daemon and the server-side modules pass their unit tests on Windows #1706
- The Android driver passes its unit tests on Windows #1707
- The iOS driver and core pass their unit tests on Windows #1708
- The CLI, updater, agent-device, console and remaining folders pass their unit tests on Windows #1709
- The repository's tooling and its tests run on Windows from Git Bash #1710
Written by an agent.
Activity