Skip to content

The repository's tooling and its tests run on Windows from Git Bash #1710

Open

Description

@V3RON

Part of #1693.

Scope

The repository's tooling (.agents/scripts/) and its tests (src/*.test.ts) run on Windows from Git Bash with Python 3, on the Windows job and for a contributor, and their files come off the list. A defect a test shows in a script is fixed here.

If it goes wrong, a hook or delivery script behaves differently on macOS after a change made for Windows, or a contributor on Windows cannot commit because a hook fails.

Technical spec

Commit 2df19f8.

Rows

  • Behaviours: B8
  • Interfaces: I1 (used)
  • Existing code: X21

Facts

# Fact Source
F1 At this commit, 20 src/*.test.ts files fail on Windows (201 tests): spawnSync sh ENOENT (review-inputs, stale-refs, worktree-script); python3 calls (slow-e2e, clock-hook); "undefined" is not valid JSON (29 in lint-rules); scripts that die at start (fast-track, ci-failures, merge-pr, claim, mutate); tool-guard paths printed with \; timeouts (budget-guard). pnpm exec vitest run --project unit --project ui-dom --reporter=json on DesktopWindows (Windows 11 23H2), 2026-11-18
F2 Tests put fake commands (gh, tsc, pnpm) on PATH as extension-less #! files joined with :. src/recurring-findings.test.ts:18, src/recurring-findings.test.ts:52-58
F3 .sh scripts and the scripts that call Python. ls .agents/scripts/*.sh (9 files); rg -n python3 .agents/scripts (awake.mjs:8, worktree.sh:46, budget-guard.mjs:63)
F4 slow-e2e.test.ts starts its idle process with os.fork() and os.setsid(). src/slow-e2e.test.ts:60-71
F5 On Windows 11, python3 is by default the Microsoft Store alias: it prints "Python was not found" instead of a version. python3 --version on DesktopWindows (Windows 11 23H2), 2026-11-18: Python was not found; run without arguments to install from the Microsoft Store…; where python3: C:\Users\<user>\AppData\Local\Microsoft\WindowsApps\python3.exe

Modules touched

Searches: rg -ln "spawnSync|execFileSync|PATH:" src/*.test.ts, rg -n "python3|\.sh\b" .agents/scripts.

  • .agents/scripts/ and scripts/ (the scripts the failing tests run: scripts/mutate.mjs from src/mutate.test.ts, scripts/slow-e2e.sh from src/slow-e2e.test.ts, scripts/build-capture.mjs from src/release-pack.test.ts), src/*.test.ts (the 20 files).
  • src/test-support/windows-skipped.ts: this group's files removed.
  • A conflict in src/test-support/windows-skipped.ts with a sibling task of CI: run the tests on Windows #1693 (neighbouring lines removed) is resolved by keeping both sides' removals.

Rules in play

  • ADR 0087 §3, §6: Git Bash with Python 3; os.fork skipped on win32.
  • docs/internal/agent-rules/toolchain.md: the tool guard's refused list is unchanged.
  • The behaviour on macOS and Linux of every script stays as it is; its existing tests pin it.

Tests

The seam is the Windows job (B1) running src/*.test.ts; model a fake command on src/recurring-findings.test.ts.

  • B8: every src/*.test.ts file passes on the Windows job and none is on the list: .sh run through bash; Python chosen by python3 --version; fake commands found on Windows (path.delimiter, a startable shim); printed paths with /; output compared with normalized line endings; os.fork skipped on win32; any script fix pinned by its test

Done when

  • pnpm test:changed passes on the branch.
  • The PR's Unit tests (Windows) job passes, and no src/*.test.ts file is left in src/test-support/windows-skipped.ts.

Out of scope

  • Running the tooling from PowerShell or cmd.exe.

Depends on

Written by an agent.

Metadata

Metadata

Assignees

Labels

os:windowsRuns on, or affects, Windows hoststask:readySpec checked. An agent may implement it once its Depends on allow.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions