Repository navigation
Description
Part of #1693.
Scope
The unit tests of the iOS driver and of core run on the Windows job and pass, and their files come off the list. iOS cannot run on Windows, but these tests fake every Apple tool, so the driver's and core's logic, owned roots included, is now checked on Windows too. A Windows-only defect they show is fixed here.
If it goes wrong, core's owned-root check refuses a Windows worker's device root, or a change to the iOS driver breaks the Windows build of a shared path.
Technical spec
Commit 2df19f8.
Rows
- Behaviours: B6
- Interfaces: I1, I3 (used)
- Existing code: X8
Facts
| # | Fact | Source |
|---|---|---|
| F1 | At this commit, 28 files of src/drivers/ios/ and src/core/ fail on Windows (702 tests), 671 with OwnedRootError: … it could not be assembled: ENOENT. With the fake reading both styles, 328 iOS and 15 core tests still fail. |
pnpm exec vitest run --project unit --project ui-dom --reporter=json on DesktopWindows (Windows 11 23H2), 2026-11-18, and the same with T1 F4's change |
| F2 | Other causes in this group: Unexpected process invocation in boot-courtesies.test.ts and index-device-set.test.ts (a scripted runner expecting a POSIX-built command); DriverCrashError: Could not start export … \private\var\tmp\devicehub-preferences.plist; EBUSY on state.db in src/core/registry.test.ts. |
pnpm exec vitest run --project unit --project ui-dom --reporter=json on DesktopWindows (Windows 11 23H2), 2026-11-18 |
Modules touched
Searches: rg -ln "OwnedRootError|ensureOwnedRoot|ScriptedProcessRunner|devicehub-preferences" src/drivers/ios src/core.
- The failing test files of
src/drivers/ios/andsrc/core/, and their helpers (src/drivers/ios/test-*.ts,src/core/test-*.ts). - Product code in those folders only where a test shows a Windows-only defect.
src/test-support/windows-skipped.ts: this group's files removed.- A conflict in
src/test-support/windows-skipped.tswith a sibling task of CI: run the tests on Windows #1693 (neighbouring lines removed) is resolved by keeping both sides' removals.
Rules in play
- ADR 0087 §2, §5.
- Drivers manual: a driver imports only core and ports.
- Core manual:
ensureOwnedRoot's refusals are unchanged.
Tests
The seam is the Windows job (B1) running the group's existing test files; model an expected path on src/core/device-root.test.ts.
- B6: every file of
src/drivers/ios/andsrc/core/passes on the Windows job and none is on the list: expected device-set, root and plist paths built withnode:pathor in the/form as their source is; scripted runners expect the host-built command;state.dbclosed before the folder is removed; any product fix pinned by its test
Done when
pnpm test:changedpasses on the branch.- The PR's
Unit tests (Windows)job passes, and no file of the group is left insrc/test-support/windows-skipped.ts.
Out of scope
- Running iOS on Windows; other folders.
Depends on
Written by an agent.
Activity
fix(ios): test helpers build the overrides paths with node:path (#1708)
fix(core): the owned-root, registry and identity tests expect Windows…
fix(ios): test helpers build the sources set and devicectl json paths…
fix(ios): fixtures spell derived paths the way the driver joins them,…
fix(ios): the last fixtures that spelled a joined path with a slash (#…
chore(ci): merge task/1706 into the Windows skip-list task (#1708)