Skip to content

The iOS driver and core pass their unit tests on Windows #1708

Open

Description

@V3RON

Part of #1693.

Scope

The unit tests of the iOS driver and of core run on the Windows job and pass, and their files come off the list. iOS cannot run on Windows, but these tests fake every Apple tool, so the driver's and core's logic, owned roots included, is now checked on Windows too. A Windows-only defect they show is fixed here.

If it goes wrong, core's owned-root check refuses a Windows worker's device root, or a change to the iOS driver breaks the Windows build of a shared path.

Technical spec

Commit 2df19f8.

Rows

  • Behaviours: B6
  • Interfaces: I1, I3 (used)
  • Existing code: X8

Facts

# Fact Source
F1 At this commit, 28 files of src/drivers/ios/ and src/core/ fail on Windows (702 tests), 671 with OwnedRootError: … it could not be assembled: ENOENT. With the fake reading both styles, 328 iOS and 15 core tests still fail. pnpm exec vitest run --project unit --project ui-dom --reporter=json on DesktopWindows (Windows 11 23H2), 2026-11-18, and the same with T1 F4's change
F2 Other causes in this group: Unexpected process invocation in boot-courtesies.test.ts and index-device-set.test.ts (a scripted runner expecting a POSIX-built command); DriverCrashError: Could not start export … \private\var\tmp\devicehub-preferences.plist; EBUSY on state.db in src/core/registry.test.ts. pnpm exec vitest run --project unit --project ui-dom --reporter=json on DesktopWindows (Windows 11 23H2), 2026-11-18

Modules touched

Searches: rg -ln "OwnedRootError|ensureOwnedRoot|ScriptedProcessRunner|devicehub-preferences" src/drivers/ios src/core.

  • The failing test files of src/drivers/ios/ and src/core/, and their helpers (src/drivers/ios/test-*.ts, src/core/test-*.ts).
  • Product code in those folders only where a test shows a Windows-only defect.
  • src/test-support/windows-skipped.ts: this group's files removed.
  • A conflict in src/test-support/windows-skipped.ts with a sibling task of CI: run the tests on Windows #1693 (neighbouring lines removed) is resolved by keeping both sides' removals.

Rules in play

  • ADR 0087 §2, §5.
  • Drivers manual: a driver imports only core and ports.
  • Core manual: ensureOwnedRoot's refusals are unchanged.

Tests

The seam is the Windows job (B1) running the group's existing test files; model an expected path on src/core/device-root.test.ts.

  • B6: every file of src/drivers/ios/ and src/core/ passes on the Windows job and none is on the list: expected device-set, root and plist paths built with node:path or in the / form as their source is; scripted runners expect the host-built command; state.db closed before the folder is removed; any product fix pinned by its test

Done when

  • pnpm test:changed passes on the branch.
  • The PR's Unit tests (Windows) job passes, and no file of the group is left in src/test-support/windows-skipped.ts.

Out of scope

  • Running iOS on Windows; other folders.

Depends on

Written by an agent.

Metadata

Metadata

Assignees

Labels

os:windowsRuns on, or affects, Windows hoststask:readySpec checked. An agent may implement it once its Depends on allow.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions