Repository navigation
fix(app-flow): target the booted device when several simulators are booted - #120
Merged
hurali97 merged 1 commit intoNov 18, 2026
Conversation
…ooted App Flow boots a specific simulator but then lists installed apps, installs Expo Go and opens the app without naming it. Before a session exists the agent-device daemon resolves those requests on their own, so with a second simulator booted they fail with AMBIGUOUS_MATCH. The listing error was swallowed as an empty list, and the sweep stopped with "Native ios app was not installed after running the ios script" even though the build had just installed it on the booted device. Pass the boot result's id as udid to apps.list, apps.install and the first apps.open, and log a failed listing instead of hiding it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@RaajYedida is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
hurali97
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With two iOS simulators booted, an App Flow sweep fails right after the native build:
The build had installed the app on the simulator App Flow booted (the Metro log shows
Installing on <device>andOpening on <device>). The agent-device request log for the follow-up listing shows the real failure:bootDeviceboots a specific device, butlistInstalledApps,ensureExpoGoInstalled(apps.install) andopenAppSession(apps.open) don't name it. No session is open yet, so the daemon resolves each request by itself and finds two equal matches.listInstalledAppsturned that error into[], which surfaces as the misleading "not installed" message.Fix
udidon iOS,serialon Android) toapps.list,apps.installand the firstapps.open.listInstalledApps,openInstalledAppandLaunchModeso the launch path can be tested without a device.Testing
packages/core/test/app-flow-device-selection.test.tsfakes a daemon with two booted simulators, so any request without audidthrows. It fails onmainand passes with this change.node --test packages/core/test/app-flow-*.test.ts: 263 passing.tsc --noEmit: no new errors. The same 25 pre-existing errors inpackages/ui/src/tracesift-controller.tsappear onmain.🤖 Generated with Claude Code