Repository navigation
Conversation
…oven (#4448) Before the first snapshot a gesture event can carry coordinates with no referenceWidth/referenceHeight, and the Swift overlay silently treated the missing pair as scale 1.0, rendering point-space input as video pixels (#4448). The renderer now requires a finite, positive, paired reference per event; events without one keep their telemetry event and the raw video but draw no marker layers. All marker paths (tap, longpress, swipe, scroll, back-swipe, pinch) refuse the old fallback, and a fully unreferenced envelope keeps the raw capture byte-for-byte. Canvas geometry is still read from the captured track itself, never from a planning viewport. The positive producer-basis propagation (native display point geometry through the gesture response into recording telemetry) remains unproven and is named as a residual; unknown geometry omits the marker. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ Approve · review of
|
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
|
The code at e6d1b8b needs live recording evidence before merge. All 18 reported checks passed at that commit, with no failed job to attribute. There are no conflicts. The reported live run covers only gestures without a reference, invokes the candidate renderer separately, and provides no recorded outputs. Could you record gestures through start, action, and stop on this commit both before a snapshot and with a valid snapshot-backed or explicit reference? Please retain the commands, telemetry, and rendered frames to show that the invalid marker is absent, the valid marker is correctly placed, and the video is preserved. A production routing or reference propagation failure could otherwise omit valid markers despite the renderer fixture passing. Renderer admission Could the renderer convert each event at admission into a renderer-local validated event carrying its reference pair, then pass that pair to the drawing functions and projection without a second check or downstream optional guards, while leaving raw telemetry untouched? Not blocking: The daemon tests inspect telemetry from unchanged construction code and pass with the old renderer; you can take or leave keeping them as producer controls and adding a regression that observes rendered output through the complete production route. Tests The broader issue’s native coordinate-basis propagation and positive no-snapshot proof remain open outside this change. Before merge, please provide the exact-head live evidence for both reference states through the production stop path and observable outputs. |
Summary
Omit gesture markers when either reference dimension is missing or invalid. Preserve gesture telemetry, the raw video, and marker placement for gestures with valid reference dimensions.
Three files change. Refs #4448. Passing verified native gesture coordinates into the recording pipeline remains open.
Validation
Base
6e18ea3349685f3cf6cec4c2e6d1104980ab2738; tested heade6d1b8b0b82487b52f7469c917f4b6df854acbd1.exactCommit=trueand eight successful checks. Five runner/replay lanes were skipped and retain their hosted or manual ownership.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.