Skip to content

fix(recording): omit markers with unknown reference dimensions - #4719

Open
thymikee wants to merge 1 commit into
mainfrom
t3/recording-overlay-coordinates
Open

thymikee wants to merge 1 commit into
mainfrom
t3/recording-overlay-coordinates

Conversation

@thymikee

@thymikee thymikee commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

Omit gesture markers when either reference dimension is missing or invalid. Preserve gesture telemetry, the raw video, and marker placement for gestures with valid reference dimensions.

Three files change. Refs #4448. Passing verified native gesture coordinates into the recording pipeline remains open.

Validation

Base 6e18ea3349685f3cf6cec4c2e6d1104980ab2738; tested head e6d1b8b0b82487b52f7469c917f4b6df854acbd1.

  • Exact affected gate passed with exactCommit=true and eight successful checks. Five runner/replay lanes were skipped and retain their hosted or manual ownership.
  • 27 focused tests passed. The prior renderer drew a marker for a missing-reference fixture. The candidate preserves a byte-identical capture for that case and still renders referenced gestures in mixed input.
  • On iPhone Duo (iOS 27.1), a live no-snapshot Settings swipe produced three gesture events without reference dimensions. Running the candidate renderer over that capture preserved the video byte-for-byte and omitted all three misplaced markers. The device was released.
  • Independent review found no findings.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

…oven (#4448)

Before the first snapshot a gesture event can carry coordinates with no
referenceWidth/referenceHeight, and the Swift overlay silently treated the
missing pair as scale 1.0, rendering point-space input as video pixels
(#4448). The renderer now requires a finite, positive, paired reference per
event; events without one keep their telemetry event and the raw video but
draw no marker layers. All marker paths (tap, longpress, swipe, scroll,
back-swipe, pinch) refuse the old fallback, and a fully unreferenced envelope
keeps the raw capture byte-for-byte. Canvas geometry is still read from the
captured track itself, never from a planning viewport.

The positive producer-basis propagation (native display point geometry
through the gesture response into recording telemetry) remains unproven and
is named as a residual; unknown geometry omits the marker.

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.39 MB 6.39 MB +471 B
Package (unpacked) 6.39 MB 6.39 MB +471 B
Package (download) 1.94 MB 1.94 MB +130 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 51.1 ms 43.7 ms -7.4 ms
CLI --help 96.4 ms 83.9 ms -12.5 ms

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve · review of e6d1b8b

No open findings.

Reviewed with this repository's own Sentinel configuration (6e18ea334968).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@thymikee

Copy link
Copy Markdown
Member Author

The code at e6d1b8b needs live recording evidence before merge. All 18 reported checks passed at that commit, with no failed job to attribute. There are no conflicts.

The reported live run covers only gestures without a reference, invokes the candidate renderer separately, and provides no recorded outputs. Could you record gestures through start, action, and stop on this commit both before a snapshot and with a valid snapshot-backed or explicit reference? Please retain the commands, telemetry, and rendered frames to show that the invalid marker is absent, the valid marker is correctly placed, and the video is preserved. A production routing or reference propagation failure could otherwise omit valid markers despite the renderer fixture passing. Renderer admission

Could the renderer convert each event at admission into a renderer-local validated event carrying its reference pair, then pass that pair to the drawing functions and projection without a second check or downstream optional guards, while leaving raw telemetry untouched?

Not blocking: The daemon tests inspect telemetry from unchanged construction code and pass with the old renderer; you can take or leave keeping them as producer controls and adding a regression that observes rendered output through the complete production route. Tests

The broader issue’s native coordinate-basis propagation and positive no-snapshot proof remain open outside this change. Before merge, please provide the exact-head live evidence for both reference states through the production stop path and observable outputs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant