Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ⛔ Block · review of
|
| Where | Finding |
|---|---|
.github/workflows/coverage-probe.yml:71 |
Probe workflow breaks the Coverage check on every PR: hidden-path upload guard now fails |
🟠 Major (2)
| Where | Finding |
|---|---|
.github/workflows/coverage-probe.yml:51 |
VITEST_MAX_WORKERS leg measures nothing: variable is never read, and CI ignores it anyway |
scripts/vitest-ci-timing-reporter.ts:45 |
Coverage-leg timing artifact is overwritten by the fuzz-worker leg; coverage wall time never recorded |
🟡 Minor (1)
| Where | Finding |
|---|---|
.github/workflows/coverage-probe.yml:7 |
Probe's cancel-in-progress concurrency group discards the timing samples it exists to collect |
Reviewed with this repository's own Sentinel configuration (655ede2796e5).
💬 Talking to Sentinel
In a finding's thread, reply with:
| Command | What it does |
|---|---|
@apex-sentinel-staging note <context> |
Adds context; Sentinel re-checks the cited code |
@apex-sentinel-staging pivot <why> |
Says the finding is wrong; Sentinel re-checks the cited code |
@apex-sentinel-staging like |
Marks the finding as useful |
@apex-sentinel-staging dislike <why> |
Marks it as not useful, so it is not raised again |
On this conversation, comment @apex-sentinel-staging review to run a full review once again.
There was a problem hiding this comment.
Apex Sentinel: 4 new findings on 029ea20. The verdict and the full list are in the summary comment.
|
Reviewed 6a6f0ab. One change is needed before this leaves draft. CI was still running at review time. coverage-probe.yml:7 uses Not blocking, take or leave: nothing sets Could the measurement stay entirely in the probe workflow? For example, run unit-ci with On the open threads: the cancel-in-progress one still applies and is minor for a draft. These no longer apply and can be resolved: the upload step is gone from the workflow at this head; the x64-8-w16 leg does not exist at this head; the timing file overwrite is avoided by the per-pid name, and nothing sets the variable anyway. Before merge, the trigger must be restricted and the Coverage and Probe checks must be green. Please also confirm that the Repo Guards gate-manifest audit accepts whichever trigger you choose. |
The Coverage job's wall time is set by how many workers its machine affords, and that is a configuration question: the same gate on 8, 16 and 32 vCPU answers it. Runs the gate on all three and reads the wall time from the Actions API's per-step timings, so nothing in the tested tree changes to observe it. Dispatch-only: a lane that starts on another PR's push would mark that PR red for a probe leg, and an unfiltered pull_request lane also makes every path reachable to every gate, which the gate-manifest audit rejects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6a6f0ab to
8a3be56
Compare
|
Apex: all four review threads are addressed at The lane is now dispatch-only, has no concurrency group, and carries no measurement code: |
|
The code at 8a3be56 is ready, and the earlier findings from #4658 (comment) are now fixed: the hidden-path upload step, the pull_request trigger, the worker-count leg, the timing reporter and the concurrency group are all gone, and the PR is one dispatch-only workflow file with three runner sizes. Not blocking: GitHub only starts a workflow_dispatch workflow whose file exists on the default branch, so this lane cannot be started from this branch, and the PR body says it must never land on main; the numbers it was meant to produce are already in #4664, so please close this PR rather than label it ready-for-human, and if you want a re-measurement later, use a throwaway branch with a pull_request trigger. I am not labeling it for that reason. The four inline threads from the earlier head no longer apply, so please resolve them: the probe breaking the Coverage check (#4658 (comment)), the worker-count leg (#4658 (comment)), the overwritten timing artifact (#4658 (comment)) and the cancel-in-progress group (#4658 (comment)). There are no conflicts. The diff is a dispatch-only workflow that no pull_request job runs, so the pending checks do not exercise it. |
|
Closing: this was the measurement lane for the Coverage runner experiment. Its numbers are recorded in #4664, and a workflow_dispatch probe can't run unless it lands on main, which this lane must never do. |
Summary
Temporary. This lane measures the
Coveragejob's wall time across runner sizes so the change can be chosen from CI numbers instead of guesses. Do not merge: the file is deleted with this PR, and the lane must never reach main.One job, a matrix over
blacksmith-8/16/32vcpu-ubuntu-2404, each running the sameunit-cigate thatCoverageruns. Wall time is read from the Actions API's per-step timings, so nothing in the tested tree is changed to observe it: no reporter, novitest.config.tsedit, no artifact upload.workflow_dispatchonly. Apull_requestlane would mark unrelated PRs red on a probe leg, and an unfiltered one also makes every path reachable to every gate, which the gate-manifest audit rejects — it faileda docs-only change still reaches the command-reference gateat head6a6f0abf06. Thecancel-in-progressgroup is gone for the same reason: a discarded run is a lost sample.Validation
Head
8a3be5673f, on top of #4662, which fixes the pid-space flake this lane found.node --experimental-strip-types scripts/gate/check.ts— gate manifest ok, 60 checks across 26 lanes.node --experimental-strip-types --test scripts/gate/audit-coverage.test.ts— 7 pass, 0 fail.npx oxfmt --check .github/workflows/coverage-probe.yml— clean.The numbers themselves are in #4664. This PR is the instrument; it closes rather than merges.