You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(android): prepare the snapshot helper before landmark waits - #3834
Prepare the Android snapshot helper with a required public CLI snapshot before each scenario's landmark wait. Cold helper installation and UiAutomation recovery no longer consume the app's 10-second observation window.
Keep the existing wait deadline and propagate failed preflights. No runtime behavior, retries or fallback policy changes.
Injected 10.2s cold installation: original sequence fails with wait_capture_stalled; preflight sequence passes. Missing landmarks still fail at 10s; an unavailable helper fails before the wait. Evidence.
Hosted Android x86_64, Apple and Linux smoke, Coverage, Integration and Repo Guards passed at 62b5c078d1. The cache build matrix was skipped; automated review is neutral. The framework connection timeout itself remains outside this fix.
This PR is ready at 62b5c07. The change looks correct, and all 16 checks pass, including the hosted Android smoke run at this head. I know of no conflicts, and nothing else stands in the way of merge. Not blocking: the 62-line evidence doc cites local logs that readers cannot open later, so keep it only if the repo keeps docs/evidence files, and the android-helper backend assert in https://github.com/callstack/agent-device/blob/62b5c07/test/integration/android-emulator-e2e/scenario-start.ts#L28 also fails on a one-shot or fallback capture, which fits the goal of not hiding helper failures; take or leave both. The hosted result is one run, and the framework UiAutomation timeout is not fixed, so a flake can now surface in the preflight itself. I did not inspect the local logs.
Preview removed because the pull request was closed.
2026-10-20 07:16 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
62b5c078d171956d2658dd8808959be60c345ca3:pnpm check:affected --run --head 62b5c078d1passed five checks,exactCommit=true,checkoutChanged=false; one device gate skipped, not passed. Independent review: no findings.wait_capture_stalled; preflight sequence passes. Missing landmarks still fail at 10s; an unavailable helper fails before the wait. Evidence.62b5c078d1. The cache build matrix was skipped; automated review is neutral. The framework connection timeout itself remains outside this fix.