Repository navigation
refactor(commands): read command inputs and output from caller hosts - #3829
Conversation
Size Report
Startup median (7 runs, lower is better):
|
467108e to
fb36192
Compare
|
Coverage follow-up: |
… host (#3753) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fb36192 to
96260a8
Compare
|
Second coverage fix: |
|
The code in 96260a8 is ready to merge. CI is still pending: 17 checks are cancelled or queued, with no failure logs, so there is nothing to attribute yet. The cancelled runs are Smoke, Lint/Typecheck/Package, Repo Guards, Coverage and Integration, and this diff touches the same routes they exercise (src/commands, src/mcp, src/cli output). No conflicts. Before merge, the Coverage, Repo Guards and Smoke lanes need to finish green on 96260a8. Not blocking, and you can take or leave these: |
|
Re-ran Apple 39294051862 once: smoke:form-input failed on fill with typed MAIN_THREAD_TIMEOUT / runner_main_thread_timeout in XCTest; smoke:webview-remote-content then timed out waiting for its link. This layer changes no Swift, so these are suspected runner/fixture flakes pending the one rerun. |
Summary
Part of #3753. Part of #3747.
Pass the caller environment and working directory through command projection, replay configuration, diff/color output, CLI call sites, IO, and MCP. Required callers and tests touch 20 files (429 gross lines). Released IO defaults remain until #3759;
createLocalArtifactAdapter()keeps its signature.Fourth layer, based on #3828. #3823 remains the top gate layer.
Validation
Head
96260a8b76fcc1ac26f370f38b4ec07aeee8debc.pnpm check:affected --run --base chore/process-globals-runtime --head 96260a8b76fcc1ac26f370f38b4ec07aeee8debcpassed; receiptrun-bAjCg9,exactCommit=true.Coverage failures were fixture races:
7e2cae20edreplaces a directory-order assumption with explicit files;288e6cceaewaits for bridge evidence contents rather than file creation. Both fixes are inherited by all layers. Upper patches are unchanged by range-diff.Prior full-check and Android daemon/provider evidence stays attributed to
e223d37244in #3823’s review-response comment. This round changes only test fixtures and ancestry. Full coverage and GitHub-owned lanes remain CI obligations.