Skip to content

test(coverage): record Linux uninstall as an accepted limitation - #3740

Merged
thymikee merged 1 commit into
mainfrom
fix/coverage-uninstall-linux-gap
Oct 16, 2026
Merged

thymikee merged 1 commit into
mainfrom
fix/coverage-uninstall-linux-gap

Conversation

@thymikee

@thymikee thymikee commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Main fails to load the command-coverage manifest: TypeError: linux.gap is not a function at test/integration/command-coverage/declarations.ts:558. That breaks Repo Guards (scripts/depgraph/affected.test.ts) on every PR.

It's a semantic merge conflict. #3717 removed the Linux known-gap builder, because no Linux row was owed work. #3720 then added the new uninstall row with linux.gap(...).

Uninstall belongs to the app-deployment family that the Linux runtime leaves unavailable: no installApp or uninstallApp capability, refused at admission. So it's recorded as linux.accepted(...) with a reason, matching install, reinstall and install-from-source. The Linux manifest test now lists uninstall among the accepted rows.

Validation

  • Before, on main 0149438fa: node --experimental-strip-types --test scripts/depgraph/affected.test.ts fails 1 of 12 with linux.gap is not a function (the CI failure on fix(ios): report the alert's own title and surface an unanswered launch confirmation #3732).
  • After: that file passes 12 of 12, and the four platform coverage suites (Linux, macOS, tvOS, web) pass 28 of 28.
  • pnpm check:affected --run --head 5f60c69d6: passed, exactCommit: true, no failed checks.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

#3720 added the uninstall row with `linux.gap(...)` after #3717 had removed the Linux
known-gap builder, so main fails to load the coverage manifest
(`TypeError: linux.gap is not a function`). Uninstall belongs to the app-deployment family
the Linux runtime leaves unavailable, so it is an accepted limitation like install,
reinstall and install-from-source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.31 MB 5.31 MB 0 B
Package (unpacked) 5.31 MB 5.31 MB 0 B
Package (download) 1.60 MB 1.60 MB -9 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 23.0 ms 22.5 ms -0.5 ms
CLI --help 63.6 ms 63.4 ms -0.2 ms

@thymikee

Copy link
Copy Markdown
Member Author

I found no problems in 5f60c69. The diff only changes the coverage declarations table and one Linux smoke test assertion, and it adds no production route.

CI is still pending. Only the two Smoke Tests jobs are queued, so nothing has failed. I did not run tsc or the Linux smoke test locally. I also did not trace the uninstall refusal on Linux end to end. I only confirmed that Linux declares no install or deploy facts, so the unavailable defaults apply. Does the uninstall fact on Linux carry exactly the unsupported-platform-leaf code that the reason text names?

There are no conflicts. This is ready to merge once the two queued Smoke Tests jobs pass.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 16, 2026
@thymikee
thymikee merged commit cc6d91a into main Oct 16, 2026
17 checks passed
@thymikee
thymikee deleted the fix/coverage-uninstall-linux-gap branch October 16, 2026 18:44
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-16 18:44 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant