Repository navigation
test(coverage): record Linux uninstall as an accepted limitation - #3740
Merged
Merged
Conversation
#3720 added the uninstall row with `linux.gap(...)` after #3717 had removed the Linux known-gap builder, so main fails to load the coverage manifest (`TypeError: linux.gap is not a function`). Uninstall belongs to the app-deployment family the Linux runtime leaves unavailable, so it is an accepted limitation like install, reinstall and install-from-source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
Contributor
Size Report
Startup median (7 runs, lower is better):
|
This was referenced Oct 16, 2026
Member
Author
|
I found no problems in 5f60c69. The diff only changes the coverage declarations table and one Linux smoke test assertion, and it adds no production route. CI is still pending. Only the two Smoke Tests jobs are queued, so nothing has failed. I did not run tsc or the Linux smoke test locally. I also did not trace the uninstall refusal on Linux end to end. I only confirmed that Linux declares no install or deploy facts, so the unavailable defaults apply. Does the uninstall fact on Linux carry exactly the There are no conflicts. This is ready to merge once the two queued Smoke Tests jobs pass. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main fails to load the command-coverage manifest:
TypeError: linux.gap is not a functionattest/integration/command-coverage/declarations.ts:558. That breaks Repo Guards (scripts/depgraph/affected.test.ts) on every PR.It's a semantic merge conflict. #3717 removed the Linux
known-gapbuilder, because no Linux row was owed work. #3720 then added the newuninstallrow withlinux.gap(...).Uninstall belongs to the app-deployment family that the Linux runtime leaves unavailable: no
installApporuninstallAppcapability, refused at admission. So it's recorded aslinux.accepted(...)with a reason, matching install, reinstall and install-from-source. The Linux manifest test now listsuninstallamong the accepted rows.Validation
0149438fa:node --experimental-strip-types --test scripts/depgraph/affected.test.tsfails 1 of 12 withlinux.gap is not a function(the CI failure on fix(ios): report the alert's own title and surface an unanswered launch confirmation #3732).pnpm check:affected --run --head 5f60c69d6: passed,exactCommit: true, no failed checks.🤖 Generated with Claude Code