Repository navigation
Conversation
The detectors created MobileDetect without arguments, so it read the headers from the global $_SERVER instead of the request they were called on. Constructed requests in tests, sub-requests and headers changed by middleware were therefore ignored. Pass the request's known User-Agent, mobile and CloudFront headers to MobileDetect instead, flattening array values set via withHeader(), and fall back to an empty User-Agent so that MobileDetect does not throw. Fixes cakephp#1114
jarovarga
force-pushed
the
ticket-1114-mobile-detectors
branch
from
October 13, 2026 06:55
92b1b67 to
ef788c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1114.
autoInitOfHttpHeadersdisabled and pass it the headers from the request's server params instead of$_SERVER.autoInitKnownHttpHeaders(). Passing all server params would include non-string values such asargv, which trigger "Array to string conversion".withHeader(), which MobileDetect cannot handle.RequestDetectorTestcovering constructed requests, changed headers, array values and requests without a User-Agent.