Repository navigation
Guard installer against a failed fileperms() call - #1117
Merged
Merged
Conversation
fileperms() returns false on failure, and false & 0777 evaluates to 0, so the installer could chmod a directory to 0007 and strip owner and group permissions. Report the failure and skip the path instead. Also drop the unused STDIN definition, throw InvalidArgumentException from the Y/n validator and report a failed chmod() via writeError(), consistent with the other failure messages. Fixes cakephp#1113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fileperms() returns false on failure, and false & 0777 evaluates to 0, so the installer could chmod a directory to 0007 and strip owner and group permissions. Report the failure and skip the path instead.
Also drop the unused STDIN definition, throw InvalidArgumentException from the Y/n validator and report a failed chmod() via writeError(), consistent with the other failure messages.
Fixes #1113